Implement Pylint #970

charliermarsh · 2022-11-30T04:52:53Z

This is the parent issue for tracking parity with Pylint. Below, we've enumerated all Pylint rules.

Rules that are checked off have been implemented in Ruff already (either as a Pylint rule, e.g., PLE0237, or by way of overlap with another linter like Pyflakes, as with missing-format-string-key).

Rules that are crossed out have been removed some consideration. (In most cases, crossed-out rules represent Pylint specific rules, e.g., rules related to Pylint configuration.)

At time of writing, many of the remaining rules require type inference and/or multi-file analysis, and aren't ready to be implemented in Ruff. (See: #970 (comment) for an enumeration.) If you're looking to start work on a specific rule, I'd suggest commenting in the issue, to get some input on whether Ruff is capable of supporting it at present.

For guidance on getting started, see the Contributing documentation.

Note: Don't implement rules that are part of Pylint extension until #1774 is completed. Don't implement rules that mainly target Python 2.

Error

Warning

Convention

Refactor

The text was updated successfully, but these errors were encountered:

charliermarsh · 2022-11-30T05:26:33Z

Need to figure out what the right "check code" approach is here. We could just start to put these under RUF. Or we could do PYE for "Pylint Error", and so on. Or we could use PYL for all of them. In either case, though, we have to allow four-digit codes, as opposed to our current three-digit codes.

JonathanPlasse · 2022-11-30T06:28:59Z

I vote for PYE as it would keep the same categories and the migration would be easier.

harupy · 2022-12-01T03:49:24Z

I'll work on unneeded-not this weekend.

relsunkaev · 2022-12-01T07:27:04Z

I would suggest PL as the pylint prefix (PLE -> PyLint Error). I think PYE might be a bit ambiguous with PYflakes, PYdocstyle, etc.

MartinBernstorff · 2022-12-01T09:33:12Z

Would absolutely love to see this happen. I know flake8 intentionally decided not to implement e.g. unexpected-keyword-arg because it required looking outside of the current file for imported functions.

I expect you've already considered this, and really hope this won't stop ruff from implementing it, but just wanted to raise it.

charliermarsh · 2022-12-01T15:22:58Z

@relsunkaev 👍 Went with PLE! The first code is checked in as PLE1142 (matching E1142 from Pylint).

charliermarsh · 2022-12-01T15:23:31Z

@MartinBernstorff - Definitely. The multi-file stuff will come, just not as quickly.

hmc-cs-mdrissi · 2022-12-08T02:41:23Z

Not sure if it should be separate issue, but looking at missing-function-docstring rule (C0116), pylint's version of it is different. It only requires that a function has docstring some in class hierarchy and does not require over-ridden methods to have a docstring. As an example,

class Foo:
  def validate(self):
    """Doc."""
    ...

class Bar(Foo):
  def validate(self):
    ...

gives no errors in pylint even though second validate is missing docstring being pylint allows inheriting one. This is very useful when implementing interface and the docstring would really be same for all things that subclass.

charliermarsh · 2023-01-05T18:53:47Z

I'd like to get pointless-statement, unnecessary-ellipsis, and unnecessary-pass in.

charliermarsh · 2023-01-05T19:20:12Z

Relevant source for defining a pointless-statement: https://github.com/PyCQA/pylint/blob/56121344f6c9c223d8e4477c0cdb58c46c840b4b/pylint/checkers/base/basic_checker.py#L447

thejcannon · 2023-01-12T16:08:49Z

A while ago I set out to find all the pylint codes make redundant by type checking.

Unfortunately that code got lost to the sands of time.

You might consider skipping those as type checking tools are very sophisticated, if you can do the effort of compiling that list

thejcannon · 2023-01-12T16:14:48Z

I've also thought very long and hard about the fact that pylint appears very sophisticated when it comes to types because it builds on astroid which works very hard to infer types based on code (pre-type-annotations)

Ideally ruff (or any modern linter) is type-aware to be as helpful as possible, but that requires either:

A Rust-implemented type checkers for Python. Short of a large company writing and maintaining this I doubt it'll keep up with the other big dogs
Having the type information be seeded to ruff. Aside from the overhead and protocol, this actually seems feasible.

dae · 2023-01-12T22:32:06Z

For what it's worth, the type awareness of pylint is the killer feature that keeps us using it in our project despite how painfully slow it is. Our first-party code is almost fully typed, and mypy is generally good at catching typing issues. We've found multiple instances where pylint caught an issue that mypy missed however - usually in third-party code with missing or incomplete type definitions, but occasionally also in our own code when mypy doesn't notice (eg due to the presence of __getattr__: python/mypy#6251).

thejcannon · 2023-01-12T22:41:02Z

Out of curiosity, have you tried pyright? It claims to have inference support for codebases that aren't fully typed.

dae · 2023-01-12T22:49:36Z

Mypy has a check_untyped_defs which sounds equivalent, and we use that. We currently rely on mypy's no_strict_optional which pyright has no equivalent to, so pyright is not currently usable on our codebase.

This PR adds [Pylint `R2004`](https://pylint.pycqa.org/en/latest/user_guide/messages/refactor/magic-value-comparison.html#magic-value-comparison-r2004) Feel free to suggest changes and additions, I have tried to maintain parity with the Pylint implementation [`magic_value.py`](https://github.com/PyCQA/pylint/blob/main/pylint/extensions/magic_value.py) See #970

diceroll123 · 2024-08-29T05:29:48Z

superfluous-parens / C0325 is covered (EDIT: partially covered) by UP034 https://docs.astral.sh/ruff/rules/UP034

lucaspar · 2024-08-29T05:43:33Z

@diceroll123 ruff doesn't flag the pylint examples though, I don't think UP034 has the same coverage.

diceroll123 · 2024-08-29T05:45:56Z

@lucaspar Fair point!

The right move here would probably be to extend UP034's capabilities.

diceroll123 · 2024-08-29T05:49:48Z

unnecessary-ellipsis / W2301 is covered by PIE790

SonGokussj4 · 2024-09-09T11:23:27Z

Hi, just a question. I'm migrating Pylint+Flake8 checks to ruff but we have E0401 which results in pylint to

E0401: Unable to import 'ada_resource.minio' (import-error)

Do I understand this right that we can't do a full migration because of this and still have to use pylint?
The import-error / E0401 is not checked in the first post.

MichaReiser · 2024-09-09T11:29:58Z

Do I understand this right that we can't do a full migration because of this and still have to use pylint?

That's correct. Ruff doesn't support multifile analysis yet.

pcorpet · 2024-09-19T07:50:31Z

Here is the script I'm using to help us migrate our Pylint config to Ruff.
https://gist.github.com/pcorpet/e776a8e794264b818c9cc6d06c11ef15

edreamleo · 2024-09-25T15:07:20Z

@charliermarsh Thank you for this tracking issue! I still use pylint because Ruff does not report no-member, as in:

class Cmdr:

    def __init__(self):
        self.a = None

class Client:

    def __init__(self):
        self.c = Cmdr()
        print(self.c.y)  # No member c.y.

    def test_c_dot_x(self):
        print(self.c.x)  # No member c.x.

II would be happy if Ruff ran slower provided Ruff could handle type inference. YMMV.

zanieb · 2024-09-25T15:16:29Z

@edreamleo we're working on type inference right now! It's a big project though :) You can follow progress with the red-knot Multi-file analysis & type inference label.

edreamleo · 2024-09-25T17:57:03Z

@zanieb Thanks for your comment! I've bookmarked red-knot.

## Summary  Related to #970. Implement [`shallow-copy-environ / W1507`](https://pylint.readthedocs.io/en/stable/user_guide/messages/warning/shallow-copy-environ.html). ## Test Plan  Unit test --------- Co-authored-by: Simon Brugman <[email protected]> Co-authored-by: Charlie Marsh <[email protected]>

bebound · 2024-11-20T08:27:42Z

Could you please add possibly-used-before-assignment / E0606 to the list?

Ref: https://pylint.pycqa.org/en/stable/user_guide/messages/error/possibly-used-before-assignment.html

MichaReiser · 2024-11-20T08:40:14Z

@bebound I don't think we can implement this rule without precise control flow analysis. We already have a similar rule in red knot, our new static analysis backend that we plan on using in ruff long-term.

bebound · 2024-11-21T04:21:08Z

@MichaReiser Thanks for the reply.

Find a minor issue in the mapping list:

- use-dict-literal / R1735 (C406)
+ use-dict-literal / R1735 (C406, C408)
- use-list-literal / R1734 (C405)
+ use-list-literal / R1734 (C408)

C408 checks dict(), list() and tuple().
C405 is unnecessary-literal-set, which converts code to set literal and is not the target of use-list-literal. Not sure if C408 is a superset of R1734.

Ref:
C405: https://docs.astral.sh/ruff/rules/unnecessary-literal-set/
C406: https://docs.astral.sh/ruff/rules/unnecessary-literal-dict/
C408: https://docs.astral.sh/ruff/rules/unnecessary-collection-call/
C411: https://docs.astral.sh/ruff/rules/unnecessary-list-call/

R1735:https://pylint.readthedocs.io/en/stable/user_guide/messages/refactor/use-dict-literal.html
R1734: https://pylint.readthedocs.io/en/stable/user_guide/messages/refactor/use-list-literal.html

charliermarsh added the rule Implementing or modifying a lint rule label Nov 30, 2022

charliermarsh mentioned this issue Nov 30, 2022

How does ruff compare to pylint? #689

Closed

charliermarsh mentioned this issue Nov 30, 2022

Implement await-outside-async / E1142 #972

Merged

charliermarsh added plugin Implementing a known but unsupported plugin and removed rule Implementing or modifying a lint rule labels Dec 31, 2022

sbdchd mentioned this issue Jan 2, 2023

Implement flake8-pie #1543

Closed

7 tasks

max0x53 mentioned this issue Jan 12, 2023

Implement PLR2004 (MagicValueComparison) #1828

Merged

BlindChickens mentioned this issue Aug 23, 2024

Inconsistent strikethrough in pylint tracking issue (#970) #13078

Closed

dhruvmanila mentioned this issue Aug 28, 2024

Feature: Port Sonar's Python scanner checks #4935

Open

This comment was marked as resolved.

Sign in to view

ahobeost mentioned this issue Sep 30, 2024

Switch to Ruff for code quality SPF-OST/pytrnsys_gui#546

Open

Quexington mentioned this issue Sep 30, 2024

Replace pylint with ruff Chia-Network/chia-blockchain#18649

Closed

emdneto mentioned this issue Oct 13, 2024

Introducing ruff as linter and formatter (basic setup) open-telemetry/opentelemetry-python#4223

Merged

diceroll123 mentioned this issue Oct 14, 2024

new rule - enforce that loop variables are not used outside the loop #13742

Closed

Quexington mentioned this issue Oct 24, 2024

[CHIA-1553] Replace pylint with ruff Chia-Network/chia-blockchain#18759

Merged

LordAro mentioned this issue Nov 6, 2024

B018 does not detect unused tuple expressions #14131

Open

harupy mentioned this issue Nov 10, 2024

[pylint] Implement shallow-copy-environ (W1507) #14241

Merged

bebound mentioned this issue Nov 15, 2024

{Pylint} Fix superfluous-parens Azure/azure-cli#30361

Open

jiasli mentioned this issue Nov 15, 2024

{Pylint} Fix consider-using-in Azure/azure-cli#30349

Draft

dairiki mentioned this issue Nov 18, 2024

Update to pylint 3.3 lektor/lektor#1208

Open

bebound mentioned this issue Nov 21, 2024

{Pylint} Fix use-dict-literal Azure/azure-cli#30308

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Pylint #970

Implement Pylint #970

charliermarsh commented Nov 30, 2022 •

edited by MichaReiser

Loading

charliermarsh commented Nov 30, 2022 •

edited

Loading

JonathanPlasse commented Nov 30, 2022

harupy commented Dec 1, 2022

relsunkaev commented Dec 1, 2022 •

edited

Loading

MartinBernstorff commented Dec 1, 2022

charliermarsh commented Dec 1, 2022

charliermarsh commented Dec 1, 2022

hmc-cs-mdrissi commented Dec 8, 2022

charliermarsh commented Jan 5, 2023

charliermarsh commented Jan 5, 2023

thejcannon commented Jan 12, 2023

thejcannon commented Jan 12, 2023

dae commented Jan 12, 2023 •

edited

Loading

thejcannon commented Jan 12, 2023

dae commented Jan 12, 2023

diceroll123 commented Aug 29, 2024 •

edited

Loading

lucaspar commented Aug 29, 2024

diceroll123 commented Aug 29, 2024

diceroll123 commented Aug 29, 2024

SonGokussj4 commented Sep 9, 2024

MichaReiser commented Sep 9, 2024

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

pcorpet commented Sep 19, 2024

edreamleo commented Sep 25, 2024 •

edited

Loading

zanieb commented Sep 25, 2024

edreamleo commented Sep 25, 2024

bebound commented Nov 20, 2024

MichaReiser commented Nov 20, 2024

bebound commented Nov 21, 2024 •

edited

Loading

Implement Pylint #970

Implement Pylint #970

Comments

charliermarsh commented Nov 30, 2022 • edited by MichaReiser Loading

Error

Warning

Convention

Refactor

charliermarsh commented Nov 30, 2022 • edited Loading

JonathanPlasse commented Nov 30, 2022

harupy commented Dec 1, 2022

relsunkaev commented Dec 1, 2022 • edited Loading

MartinBernstorff commented Dec 1, 2022

charliermarsh commented Dec 1, 2022

charliermarsh commented Dec 1, 2022

hmc-cs-mdrissi commented Dec 8, 2022

charliermarsh commented Jan 5, 2023

charliermarsh commented Jan 5, 2023

thejcannon commented Jan 12, 2023

thejcannon commented Jan 12, 2023

dae commented Jan 12, 2023 • edited Loading

thejcannon commented Jan 12, 2023

dae commented Jan 12, 2023

diceroll123 commented Aug 29, 2024 • edited Loading

lucaspar commented Aug 29, 2024

diceroll123 commented Aug 29, 2024

diceroll123 commented Aug 29, 2024

SonGokussj4 commented Sep 9, 2024

MichaReiser commented Sep 9, 2024

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

pcorpet commented Sep 19, 2024

edreamleo commented Sep 25, 2024 • edited Loading

zanieb commented Sep 25, 2024

edreamleo commented Sep 25, 2024

bebound commented Nov 20, 2024

MichaReiser commented Nov 20, 2024

bebound commented Nov 21, 2024 • edited Loading

charliermarsh commented Nov 30, 2022 •

edited by MichaReiser

Loading

charliermarsh commented Nov 30, 2022 •

edited

Loading

relsunkaev commented Dec 1, 2022 •

edited

Loading

dae commented Jan 12, 2023 •

edited

Loading

diceroll123 commented Aug 29, 2024 •

edited

Loading

edreamleo commented Sep 25, 2024 •

edited

Loading

bebound commented Nov 21, 2024 •

edited

Loading