{Pylint} Fix use-dict-literal #30308
Open
+169
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atombrella
requested review from
jsntcy,
zhoxing-ms,
evelyn-ys,
calvinhzy,
yanzhudd,
kairu-ms,
necusjz,
wangzelin007,
jiasli and
bebound
as code owners
❌AzureCLI-FullTest
|
|
Hi @atombrella, |
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
the
customer-reported
|
Thanks for your contribution. The disabled rules were introduced in #20192. I think it's okay to fix them. Could you please also remove them from |
bebound
changed the title
dict() with {}, set([]) with set()
I can do that, but it'll be quite a bit of work. You unfortunately still accept PRs with |
|
#20192 was created by me. I ignored them simply because we didn't have bandwidth to work on those issues. So yes, please also remove them from Line 45 in be4af71 |
|
I will fix |
12 tasks
|
@atombrella, could you remove Line 45 in be4af71 |
jiasli
changed the title
dict() with {}, set([]) with set()
kairu-ms
previously approved these changes
Nov 20, 2024
|
More errors are discovered after disabling @atombrella, could you help fix them too? |
Yes. I'll try to allocate some time this week to fix them :) |
atombrella
force-pushed
the
pythonic_dict
branch
from
62b9ac1
to
2ab0464
Compare
|
I've fixed them. There weren't that many after all :) There are quite of cases like: if self.__loadbalancer_models is None:
load_balancer_models = {}
load_balancer_models["ManagedClusterLoadBalancerProfile"] = self.ManagedClusterLoadBalancerProfile
load_balancer_models[
"ManagedClusterLoadBalancerProfileManagedOutboundIPs"
] = self.ManagedClusterLoadBalancerProfileManagedOutboundIPs
load_balancer_models[
"ManagedClusterLoadBalancerProfileOutboundIPs"
] = self.ManagedClusterLoadBalancerProfileOutboundIPs
load_balancer_models[
"ManagedClusterLoadBalancerProfileOutboundIPPrefixes"
] = self.ManagedClusterLoadBalancerProfileOutboundIPPrefixes
load_balancer_models["ResourceReference"] = self.ResourceReference
self.__loadbalancer_models = SimpleNamespace(**load_balancer_models)
return self.__loadbalancer_modelsIf you use PyCharm, it provides a quick and easy way to directly create the dictionary in a single-step. https://pypi.org/project/flake8-comprehensions/ has lots of valuable suggestions. I've fixed the |
atombrella
force-pushed
the
pythonic_dict
branch
from
53c7e42
to
13492c3
Compare
Some |
This is more Pythonic. Signed-off-by: Mads Jensen <[email protected]>
atombrella
force-pushed
the
pythonic_dict
branch
from
13492c3
to
9350692
Compare
I did check with ruff to find all of them :) I hadn't heard of ruff before, it seems to quite useful/powerful. C408 is indeed a superset of https://pylint.readthedocs.io/en/stable/user_guide/messages/refactor/use-dict-literal.html There are many great suggestions from flake8-comprehensions. For instance, I experimented briefly today with one of the examples from https://www.geeksforgeeks.org/python-dictionary-fromkeys-method/ to check the performance improvements of using Note that in some places, I reformatted the code slightly. IMO it improves readability to split comprehensions over more lines. One case is: info_dict = {
lun: {"managedDisk": {'storageAccountType': None}}
for lun in dummy_expected if lun != "os"
} |
atombrella
force-pushed
the
pythonic_dict
branch
from
fc63718
to
0aeed99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Various commands are "affected" by this. Please check the diff.
Description
flake8-comprehensions has the two suggestions I try to remedy.
You can check the marginal benefits with
timeitinipython.I wonder why these two rules are disabled in
pylintrc. Maybe it's for historic reasons.The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.