[CHIA-1553] Replace pylint with ruff

[Quexington]

Blatant plagiarism of #18649 with less emojis and politics :)

Ruff is a python linter and formatter written entirely in Rust that aims to reimplement many of the most popular tools in a way where they can run hundreds of times faster. It's used to lint the source of many major projects like Mypy, Poetry, PyInstaller, pytest, and even Pylint, which this PR hopes to replace.

The introduced scope of ruff here is very limited compared to what it can do. We're only replacing pylint in this PR even though this tool could in theory absorb 4 or 5 more of our pre-commit jobs (and run them all in a fraction of the time). The reason for targeting pylint is two-fold: 1) pylint cannot run in pre-commit because it's so slow. This often results in unexpected CI failures that devs would have much rather caught at commit time. 2) pylint at once wants to check type related information and at the same time is pretty bad at it. This is a known issue in pylint that results in many false positives and while they're working to improve it, they are slow to respond to false positive issues and have seeming architectural issues that prevent them from addressing some of the more annoying failures like with respect to wrappers and dataclasses.

Ruff does not have exact 1:1 parity with pylint, however, they are working in that direction: astral-sh/ruff#970. They also don't attempt type inference that they're bad at, which means we're trading some linting coverage for less false positives and pylint: disable= statements in our codebase.

In terms of Ruff ergonomics, many errors can be fixed automatically (and are by pre-commit) and errors that cannot be fixed give much more descriptive formatting to help developers solve them. Ignoring ruff errors works like flake8 (because it can replace it) by saying # noqa: <error code>.

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
pypi/[email protected]	environment, eval, filesystem, network, shell, unsafe	0	36.2 MB	astral-bot, crmarsh, zanie

🚮 Removed packages: pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected]

View full report↗︎

[emlowe]

@SocketSecurity ignore pypi/[email protected]

[wallentx]

Pff.. chicken

[github-actions]

File	Coverage	Missing Lines
chia/_tests/build-init-files.py	0.0%	lines 92
chia/_tests/util/misc.py	0.0%	lines 351
chia/_tests/wallet/rpc/test_wallet_rpc.py	0.0%	lines 284
chia/server/chia_policy.py	50.0%	lines 264, 295
chia/util/db_wrapper.py	0.0%	lines 117
chia/util/dump_keyring.py	0.0%	lines 89
chia/util/task_timing.py	0.0%	lines 131, 165

Total	Missing	Coverage
75 lines	9 lines	88%

[emlowe]

Coverage diff exemption