-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Mostly) Replace flake8 with Ruff #18801
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
label
Oct 30, 2024
Quexington
commented
Oct 31, 2024
Quexington
changed the title
Replace flake8 with Ruff
(Mostly) Replace flake8 with Ruff
Oct 31, 2024
github-actions
bot
added
the
merge_conflict
Branch has conflicts that prevent merge to main
label
Oct 31, 2024
Quexington
force-pushed
the
quex.replace_flake8_with_ruff
branch
from
October 31, 2024 19:06
6ac65b4
to
fe1c62e
Compare
github-actions
bot
removed
the
merge_conflict
Branch has conflicts that prevent merge to main
label
Oct 31, 2024
|
Pull Request Test Coverage Report for Build 11618368919Details
💛 - Coveralls |
altendky
approved these changes
Nov 1, 2024
emlowe
approved these changes
Nov 1, 2024
Coverage exemption |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
ready_to_merge
Submitter and reviewers think this is ready
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR #18759 for more information about Ruff. This PR continues the work of simplifying our pre-commit workflow by (mostly) replacing another one of our tools with Ruff.
This only takes a partial step towards eliminating flake8 for auditability reasons. One difference between flake8 and Ruff is that Ruff is more strict wrt unused variables in that it does not allow them even during tuple deconstructions. There's been some debate about whether this should be a separate rule: astral-sh/ruff#8884 but for now, it all lives under the same code. We don't want to ignore that code generally, but there's approximately 540 errors to fix if we switch to linting it with Ruff. In order to preserve PR and code history auditability, I'll follow up with a PR to fix those errors by themselves so that the other rules that are applied can be viewed in this PR.