Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHIA-1680] Finish replacing flake8 with Ruff #18802

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[CHIA-1680] Finish replacing flake8 with Ruff #18802

wants to merge 3 commits into from
+430 −493

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented Oct 31, 2024 •
edited
Loading

This is the follow up to #18801 with this the changes wrt F841 and the final removal of flake8.

Reviewing the three commits individually is likely the best way to go about reviewing this.

@Quexington Quexington added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Oct 31, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Oct 31, 2024
@Quexington Quexington force-pushed the quex.finish_replacing_flake8_with_ruff branch from 949cbe6 to 3af739d Compare October 31, 2024 19:40
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Oct 31, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Oct 31, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Oct 31, 2024
@Quexington Quexington changed the title Finish replacing flake8 with Ruff [CHIA-1680] Finish replacing flake8 with Ruff Oct 31, 2024
Base automatically changed from quex.replace_flake8_with_ruff to main November 1, 2024 16:55
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Nov 1, 2024
@Quexington Quexington force-pushed the quex.finish_replacing_flake8_with_ruff branch from 3af739d to 0ba4867 Compare November 1, 2024 17:14
@Chia-Network Chia-Network deleted a comment from github-actions bot Nov 1, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Nov 1, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Nov 1, 2024
@Quexington Quexington marked this pull request as ready for review November 1, 2024 17:30
@Quexington Quexington requested review from a team as code owners November 1, 2024 17:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

File Coverage Missing Lines
chia/_tests/conftest.py 66.7% lines 758
chia/_tests/util/benchmark_cost.py 0.0% lines 69, 71-77
chia/cmds/plotnft_funcs.py 0.0% lines 203
chia/daemon/server.py 50.0% lines 1283
Total Missing Coverage
327 lines 11 lines 96%

@emlowe
Copy link
Contributor

emlowe commented Nov 1, 2024

Coverage exemption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altendky altendky altendky approved these changes

@emlowe emlowe emlowe approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Quexington @emlowe @altendky