DerivationPath Alias #471

aaronmgdr · 2024-12-03T12:44:20Z

Description

add alias for celoLegacy to derivationPath flag on account:new command

This is currently same behavior as the default but that will change in a future version.

Other changes

shift imports to be direct from celo/base instead of reexported from cryptographic utils

Related issues

part of investigate multi derivation path lookups (celo, eth, x ledger variations) #448

PR-Codex overview

This PR introduces the DerivationPathAliases enumeration and updates the account:new command to support new aliases for derivation paths. It also improves documentation and error handling related to derivation paths.

Detailed summary

Added DerivationPathAliases enum in packages/sdk/base/src/account.ts.
Exported ETHEREUM_DERIVATION_PATH and DerivationPathAliases.
Updated account:new command to support celoLegacy alias.
Enhanced error handling for invalid derivation paths.
Updated documentation to reflect changes in derivation paths.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

import derivation info from celo base instead of thru cryptographic-utils

changeset-bot · 2024-12-03T12:44:24Z

🦋 Changeset detected

Latest commit: 13bdb93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@celo/celocli	Minor
@celo/base	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2024-12-03T12:52:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.44%. Comparing base (059141e) to head (13bdb93).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #471      +/-   ##
==========================================
+ Coverage   70.33%   73.44%   +3.11%     
==========================================
  Files         294      240      -54     
  Lines       11337    10180    -1157     
  Branches     1680     1611      -69     
==========================================
- Hits         7974     7477     -497     
+ Misses       3212     2610     -602     
+ Partials      151       93      -58

Components	Coverage Δ
celocli	`85.23% <100.00%> (+10.05%)`	⬆️
sdk	`68.94% <100.00%> (+0.02%)`	⬆️
wallets	`52.72% <ø> (ø)`
viem-sdks	`95.08% <ø> (ø)`

packages/cli/src/commands/account/new.ts

packages/sdk/base/src/account.ts

packages/cli/src/commands/account/new.ts

aaronmgdr · 2024-12-04T10:32:57Z

packages/cli/src/commands/account/new.ts

@@ -134,9 +155,10 @@ export default class NewAccount extends BaseCommand {
    const accountAddress = toChecksumAddress(privateKeyToAddress(keys.privateKey))

    if (derivationPath === CELO_DERIVATION_PATH_BASE) {
+      // TODO tell them they can configure the default derivation path


will handle once that functionality is done in next pr

I'd remove that TODO tbh

…cleaning run mainifest every time we build (this enables commands to be updated) since build already calls manifest dont need to call again in prepack

aaronmgdr · 2024-12-04T15:25:28Z

its saying this pr increased celocli test coverage 10pts to 85% but i do not believe it. i added tests but not that many

nicolasbrugneaux · 2024-12-05T14:42:53Z

packages/cli/src/commands/account/new.ts

    }
-    return derivationPath
+
+    // if it is a valid BIP 44 it will be returned thanks mr robot


shazarre · 2024-12-05T14:45:33Z

packages/cli/src/commands/account/new.ts

@@ -134,9 +155,10 @@ export default class NewAccount extends BaseCommand {
    const accountAddress = toChecksumAddress(privateKeyToAddress(keys.privateKey))

    if (derivationPath === CELO_DERIVATION_PATH_BASE) {
+      // TODO tell them they can configure the default derivation path


I'd remove that TODO tbh

packages/cli/src/commands/account/new.ts

aaronmgdr

Hmm there is a small issue (not really but kinda)

what we want passed into --derivationPath on account:new isnt actually a full BIP 44 path https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki

its just the first 3 levels m / purpose' / coin_type' / account'

since coin_type and account_index are handled by separate flags (or just defualted to zero)

gitguardian · 2024-12-06T09:38:01Z

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
14107627	Triggered	Generic High Entropy Secret	`7b28cd2`	packages/cli/src/commands/account/new.test.ts	View secret
14107625	Triggered	Generic High Entropy Secret	`7b28cd2`	packages/cli/src/commands/account/new.test.ts	View secret
14107624	Triggered	Generic High Entropy Secret	`7b28cd2`	packages/cli/src/commands/account/new.test.ts	View secret
14107626	Triggered	Generic High Entropy Secret	`7b28cd2`	packages/cli/src/commands/account/new.test.ts	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

.changeset/nice-fireants-cheat.md

.changeset/tasty-schools-reply.md

packages/cli/src/commands/account/new.ts

@aaronmgdr

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. ⚠️

⚠️

⚠️ `master` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `master`. ⚠️

⚠️

⚠️ # Releases ## @celo/[email protected] ### Minor Changes - [#471](#471) [`26b9779`](26b9779) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - For `account:new` command add alias "celoLegacy" to the `--derivationPath` flag ### Patch Changes - [#471](#471) [`26b9779`](26b9779) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - when account:new is called it displays the full bip44 derivation path in the output. Before it would miss the last 2 positions. - [#480](#480) [`b83d8c4`](b83d8c4) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Recommended node version is now node 20 - Updated dependencies \[[`b83d8c4`](b83d8c4), [`26b9779`](26b9779)]: - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Minor Changes - [#471](#471) [`26b9779`](26b9779) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - add DerivationPathAliases export ## @celo/[email protected] ### Patch Changes - [#480](#480) [`b83d8c4`](b83d8c4) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Recommended node version is now node 20 - Updated dependencies \[[`26b9779`](26b9779)]: - @celo/[email protected]  --- ## PR-Codex overview This PR focuses on updating the versions of various `@celo` packages, including `@celo/base` and `@celo/contractkit`, along with minor changes and enhancements in the CLI and ContractKit functionalities. ### Detailed summary - Updated `@celo/base` from `7.0.0-beta.0` to `7.0.0-beta.1`. - Updated `@celo/contractkit` from `9.0.0-beta.4` to `9.0.0-beta.5`. - Updated `@celo/celocli` from `6.0.0-beta.6` to `6.0.0-beta.7`. - Added `DerivationPathAliases` export in `@celo/base`. - Added alias "celoLegacy" for `--derivationPath` in `account:new` command. - Displayed full BIP44 derivation path in `account:new` output. - Recommended node version updated to node 20. - Updated dependencies in multiple packages. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`  Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

@aaronmgdr

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. # Releases ## @celo/[email protected] ### Major Changes - [#407](#407) [`3890220`](3890220) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Remove transfer:gold -- this was an old alias for transfer:celo which has the same functionality - [#412](#412) [`23d36cc`](23d36cc) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Remove `celocli validator:force-deaffiliate` This command was only ever usable pre mainnet launch. The force deaffiliate method it would call is only callable by one of the whitelisted Slasher Contracts. To force removal of validator with poor uptime use `celocli validator:downtime-slash` or to sever association with a validator from your group use `celocli validator:deaffiliate` - [#339](#339) [`87223ba`](87223ba) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Remove support for reserve:\* commands. As foretold by <https://forum.celo.org/t/sunset-of-reserve-commands/8454> - [#407](#407) [`3890220`](3890220) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Remove account:recover-old This was meant to be a temporary command for migrating account from a beta version of Valora to the release version. Please use a previous version of celocli if you need to make this one time recovery. - [#343](#343) [`54741cc`](54741cc) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Remove commands identity:identifier, identity:get-attestations See <https://forum.celo.org/t/rfc-deprecation-of-celocli-identity-commands/8676> ### Minor Changes - [#420](#420) [`fb08485`](fb08485) Thanks [@shazarre](https://github.com/shazarre)! - Adds support for safe integration for L2 hotfix security council approvals - [#429](#429) [`5b02036`](5b02036) Thanks [@shazarre](https://github.com/shazarre)! - Removes L2 BLS keys support for account:authorize - [#447](#447) [`7bc05c2`](7bc05c2) Thanks [@shazarre](https://github.com/shazarre)! - validator:signed-blocks not supported on L2 anymore, fixes validator:status L2 - [#471](#471) [`26b9779`](26b9779) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - For `account:new` command add alias "celoLegacy" to the `--derivationPath` flag - [#459](#459) [`0e559c7`](0e559c7) Thanks [@shazarre](https://github.com/shazarre)! - Introduces a new command `account:claim-rpc-url` allowing to claim RPC URLs - [`76045eb`](76045eb) Thanks [@shazarre](https://github.com/shazarre)! - BLS keys are now optional as being deprecated on L2, validator:register and releasecelo:authorize no longer require them in L2 context ### Patch Changes - [#421](#421) [`7d42a05`](7d42a05) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - fix governance:build-proposal with contracts from mento or which use solidity 0.8 - [#463](#463) [`eba89a3`](eba89a3) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Add GovernanceSlasher to RegisteredContractsEnum - [#389](#389) [`5a0a922`](5a0a922) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Add warning that ETH derivation path will be the default in a future major breaking change. - [#425](#425) [`952bc81`](952bc81) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - deprecates the flags --whitelisters and --nonwhitelisters from the governance:show command - [#456](#456) [`d5c9204`](d5c9204) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Fix rewards:show for L2 - [#472](#472) [`1df8688`](1df8688) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Dont show flags for privateKey, gasCurrency, useLedger, and related flags in help for commands which dont actually make use of them. - [#395](#395) [`693f6e7`](693f6e7) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect message where the transfered token was used as gas token in the messaging but not in actuality - [#395](#395) [`693f6e7`](693f6e7) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix Transfering, exchanging cusd (and other fee tokens) and or using gasCurrency flag with ledger devices prior to 1.2 - [#471](#471) [`26b9779`](26b9779) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - when account:new is called it displays the full bip44 derivation path in the output. Before it would miss the last 2 positions. - [#480](#480) [`b83d8c4`](b83d8c4) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Recommended node version is now node 20 - [#452](#452) [`2283374`](2283374) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Show deprecated warning on flags which will be removed after cel2 launch - [#389](#389) [`5a0a922`](5a0a922) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix: account:new can now be called without a node - [#449](#449) [`97f0a53`](97f0a53) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Show --node and --useLedger flags when --help is called. Show aliases for networks in --node help - [#452](#452) [`2283374`](2283374) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - use onchain values instead of static for lock requirements - [#450](#450) [`9558b56`](9558b56) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Gracefully throw if --estimate wasnt passed on L1 - [#427](#427) [`ee33677`](ee33677) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Change a dependency to use npm rather than github - Updated dependencies \[[`eba89a3`](eba89a3), [`43e8474`](43e8474), [`693f6e7`](693f6e7), [`7d42a05`](7d42a05), [`c4b9c6d`](c4b9c6d), [`7bc05c2`](7bc05c2), [`5a0a922`](5a0a922), [`0e559c7`](0e559c7), [`33ad4aa`](33ad4aa), [`d988d31`](d988d31), [`42d091f`](42d091f), [`b83d8c4`](b83d8c4), [`36c4369`](36c4369), [`4ef76eb`](4ef76eb), [`76045eb`](76045eb), [`38fe4d0`](38fe4d0), [`26b9779`](26b9779), [`33ad4aa`](33ad4aa), [`b366827`](b366827), [`a23246e`](a23246e), [`fb08485`](fb08485), [`7d42a05`](7d42a05), [`ee33677`](ee33677), [`d5c9204`](d5c9204)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Major Changes - [#228](#228) [`4ef76eb`](4ef76eb) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - remove deprecated functions and consts exported from ./contacts and ./displayformating. ./currencies and ./phonenumbers. If these are used by your app we recommend to inline the functions from the previous release. - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/contacts.ts> - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/displayFormatting.ts> - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/phoneNumbers.ts> <https://github.com/celo-org/developer-tooling/tree/%40celo/wallet-base%406.0.1/packages/sdk/base/src> Full List of removed exports -- ContactPhoneNumber, MinimalContact, getContactPhoneNumber, isContact, CURRENCY_ENUM, Currency, CURRENCIES, resolveCurrency, SHORT_CURRENCIES, currencyToShortMap | getErrorMessage | anonymizedPhone | getContactNameHash ### Minor Changes - [#471](#471) [`26b9779`](26b9779) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - add DerivationPathAliases export ## @celo/[email protected] ### Major Changes - [#340](#340) [`33ad4aa`](33ad4aa) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Removes all exports under the lib/identity folder. These have been move to a new @celo/metadata-claims package and should be imported from there. Note that folder structure is also flattened slightly. so replace `@celo/contractkit/lib/identity/claims/` with `@celo/metadata-claims/lib/` example ```diff - import { createAccountClaim } from '@celo/contractkit/lib/identity/claims/account' + import { createAccountClaim } from '@celo/metadata-claims/lib/account' ``` ```diff - import { ContractKit, IdentityMetadataWrapper, newKitFromWeb3 } from '@celo/contractkit' - import { ClaimTypes } from '@celo/contractkit/lib/identity' + import { ContractKit, newKitFromWeb3 } from '@celo/contractkit' + import { ClaimTypes, IdentityMetadataWrapper } from '@celo/metadata-claims' ``` Note that Contractkit is Not a dependency. Instead when using `IdentityMetadataWrapper` you should make an object that satisfis the `AccountMetadataSignerGetters` type ```typescript import { AccountMetadataSignerGetters } from '@celo/metadata-claims/lib/types' ``` using viem it would be like ```typescript const accountsMetaDataSignerGetters: AccountMetadataSignerGetters = { isAccount: async (address: string) => accounts.read.isAccount([address as Address]), getValidatorSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), getVoteSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), getAttestationSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), } ``` ### Minor Changes - [#447](#447) [`7bc05c2`](7bc05c2) Thanks [@shazarre](https://github.com/shazarre)! - Exposes EpochManager.getElectedSigners contract method - [`76045eb`](76045eb) Thanks [@shazarre](https://github.com/shazarre)! - ValidatorsWrapper: add registerValidatorNoBls to allow registration without BLS keys which are not supported in L2 ### Patch Changes - [#463](#463) [`eba89a3`](eba89a3) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Add GovernanceSlasher to RegisteredContractsEnum - [#467](#467) [`43e8474`](43e8474) Thanks [@shazarre](https://github.com/shazarre)! - fix: add transferOwnership() to proxy abi list - [#446](#446) [`42d091f`](42d091f) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Bump @celo/abis-12 - [#480](#480) [`b83d8c4`](b83d8c4) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Recommended node version is now node 20 - [#455](#455) [`36c4369`](36c4369) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Mark contract wrapper methods that will not work on L2 because solidity contracts have onlyL1 modifier as deprecated. | Deprecated Contract / Method | Replacement or none | | -------------------------------------------- | ----------------------------------------- | | Validators#registerValidator | Validators#registerValidatorNoBLS | | BlockchainParams#getEpochNumberOfBlock | EpochManager#getEpochNumberOfBlock | | BlockchainParams#getFirstBlockNumberForEpoch | EpochManager#getFirstBlockAtEpoch | | Election#getCurrentValidatorSigners | EpochManager#getElectedSigners | | Election#getGroupEpochRewards | Election#getGroupEpochRewardsBasedOnScore | | GovernanceSlasher#slash | GovernanceSlasher#slashL2 | | DoubleSigningSlasher | X | | DowntimeSlasher | X | - [#400](#400) [`38fe4d0`](38fe4d0) Thanks [@shazarre](https://github.com/shazarre)! - Renames `getElected` and its usages to `getElectedAccounts` for `EpochManagerWrapper` - [#456](#456) [`d5c9204`](d5c9204) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Backwards compat for some methods using epoch's block numbers - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`d988d31`](d988d31), [`4ef76eb`](4ef76eb), [`26b9779`](26b9779), [`fb08485`](fb08485)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Major Changes - [#340](#340) [`33ad4aa`](33ad4aa) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Introducing @celo/metadata-claims These are a series of functions extracted from @celo/contractkit since they didnt strictly need depend on contractkit itsefl. Developers can now use IdentityMetadataWrapper with any js rpc library like ethers or viem or web3js without being forced to import ContractKit. Instead when using `IdentityMetadataWrapper` you should make an object that satisfis the `AccountMetadataSignerGetters` type ```typescript import { AccountMetadataSignerGetters } from '@celo/metadata-claims/lib/types' ``` using viem it would be like ```typescript const accountsMetaDataSignerGetters: AccountMetadataSignerGetters = { isAccount: async (address: string) => accounts.read.isAccount([address as Address]), getValidatorSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), getVoteSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), getAttestationSigner: async (address: string) => accounts.read.getValidatorSigner([address as Address]), } ``` ### Minor Changes - [#459](#459) [`0e559c7`](0e559c7) Thanks [@shazarre](https://github.com/shazarre)! - Add support for RPC_URL claim type ### Patch Changes - [#475](#475) [`b366827`](b366827) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Publish lib instead of src - Updated dependencies \[[`4ef76eb`](4ef76eb), [`26b9779`](26b9779)]: - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Major Changes - [#228](#228) [`4ef76eb`](4ef76eb) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - remove deprecated functions and consts exported from ./contacts and ./displayformating. ./currencies and ./phonenumbers. If these are used by your app we recommend to inline the functions from the previous release. - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/contacts.ts> - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/displayFormatting.ts> - <https://github.com/celo-org/developer-tooling/blob/%40celo/wallet-base%406.0.1/packages/sdk/base/src/phoneNumbers.ts> <https://github.com/celo-org/developer-tooling/tree/%40celo/wallet-base%406.0.1/packages/sdk/base/src> Full List of removed exports -- ContactPhoneNumber, MinimalContact, getContactPhoneNumber, isContact, CURRENCY_ENUM, Currency, CURRENCIES, resolveCurrency, SHORT_CURRENCIES, currencyToShortMap | getErrorMessage | anonymizedPhone | getContactNameHash ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb), [`26b9779`](26b9779)]: - @celo/[email protected] ## @celo/[email protected] ### Major Changes - [#344](#344) [`6bba5e3`](6bba5e3) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Initial release ### Patch Changes - [#443](#443) [`a23246e`](a23246e) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Safer handling of v from device - [#427](#427) [`ee33677`](ee33677) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Change a dependency to use npm rather than github - Updated dependencies \[[`4ef76eb`](4ef76eb), [`26b9779`](26b9779)]: - @celo/[email protected] ## @celo/[email protected] ### Minor Changes - [#420](#420) [`fb08485`](fb08485) Thanks [@shazarre](https://github.com/shazarre)! - Now CeloProvider can be wrapped in EIP-1193 partially compatible object (request + args) ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb), [`26b9779`](26b9779)]: - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#400](#400) [`38fe4d0`](38fe4d0) Thanks [@shazarre](https://github.com/shazarre)! - Upgrades to latest devchain - [#446](#446) [`42d091f`](42d091f) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Bump @celo/abis-12 - [#420](#420) [`fb08485`](fb08485) Thanks [@shazarre](https://github.com/shazarre)! - Adds actual Celo chain id when running anvil - Updated dependencies \[[`fb08485`](fb08485)]: - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#389](#389) [`5a0a922`](5a0a922) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Add warning that ETH derivation path will be the default in a future major breaking change. - Updated dependencies \[[`4ef76eb`](4ef76eb), [`26b9779`](26b9779)]: - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`eba89a3`](eba89a3), [`43e8474`](43e8474), [`7bc05c2`](7bc05c2), [`33ad4aa`](33ad4aa), [`42d091f`](42d091f), [`b83d8c4`](b83d8c4), [`36c4369`](36c4369), [`4ef76eb`](4ef76eb), [`76045eb`](76045eb), [`38fe4d0`](38fe4d0), [`26b9779`](26b9779), [`fb08485`](fb08485), [`d5c9204`](d5c9204)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#463](#463) [`eba89a3`](eba89a3) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Add GovernanceSlasher to RegisteredContractsEnum - [#421](#421) [`7d42a05`](7d42a05) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - minor update to inquirer lib - [#446](#446) [`42d091f`](42d091f) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Bump @celo/abis-12 - [#421](#421) [`7d42a05`](7d42a05) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix being unable to use 08 and mento contracts with proposal builder - Updated dependencies \[[`eba89a3`](eba89a3), [`43e8474`](43e8474), [`7bc05c2`](7bc05c2), [`33ad4aa`](33ad4aa), [`42d091f`](42d091f), [`b83d8c4`](b83d8c4), [`36c4369`](36c4369), [`4ef76eb`](4ef76eb), [`76045eb`](76045eb), [`38fe4d0`](38fe4d0), [`26b9779`](26b9779), [`fb08485`](fb08485), [`d5c9204`](d5c9204)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`d988d31`](d988d31), [`4ef76eb`](4ef76eb)]: - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb), [`26b9779`](26b9779)]: - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - Updated dependencies \[[`4ef76eb`](4ef76eb), [`26b9779`](26b9779), [`fb08485`](fb08485)]: - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - [#408](#408) [`d988d31`](d988d31) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Improve support for celo-legacy and modern txs within ledger - Updated dependencies \[[`4ef76eb`](4ef76eb), [`26b9779`](26b9779), [`fb08485`](fb08485)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - Updated dependencies \[[`4ef76eb`](4ef76eb), [`26b9779`](26b9779)]: - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`d988d31`](d988d31), [`4ef76eb`](4ef76eb), [`fb08485`](fb08485)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`d988d31`](d988d31), [`4ef76eb`](4ef76eb), [`26b9779`](26b9779), [`fb08485`](fb08485)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`d988d31`](d988d31), [`4ef76eb`](4ef76eb), [`fb08485`](fb08485)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#395](#395) [`693f6e7`](693f6e7) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix issue where ledger running celo firmware app 1.1.10 could not send fee token transactions or perform and interactions with those contracts - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - [#408](#408) [`d988d31`](d988d31) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Improve support for celo-legacy and modern txs within ledger - [#443](#443) [`a23246e`](a23246e) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Safer handling of v from device - [#427](#427) [`ee33677`](ee33677) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Change a dependency to use npm rather than github - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`d988d31`](d988d31), [`4ef76eb`](4ef76eb), [`26b9779`](26b9779), [`fb08485`](fb08485)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - [#408](#408) [`d988d31`](d988d31) Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Improve support for celo-legacy and modern txs within ledger - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`d988d31`](d988d31), [`4ef76eb`](4ef76eb), [`26b9779`](26b9779), [`fb08485`](fb08485)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] - @celo/[email protected] ## @celo/[email protected] ### Patch Changes - [#434](#434) [`c4b9c6d`](c4b9c6d) Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Force patch bump wallets to deal with version conflict - Updated dependencies \[[`c4b9c6d`](c4b9c6d), [`d988d31`](d988d31), [`4ef76eb`](4ef76eb), [`fb08485`](fb08485)]: - @celo/[email protected] - @celo/[email protected] - @celo/[email protected]  --- ## PR-Codex overview This PR primarily focuses on updating the versions of various `@celo` packages from beta versions to stable releases, along with some minor dependency updates and changelog entries for new features and fixes. ### Detailed summary - Deleted multiple `.changeset` files. - Updated versions for `@celo/base`, `@celo/utils`, `@celo/connect`, `@celo/contractkit`, and several wallet packages from beta to stable. - Added changelog entries for patch updates in various packages. - Improved support for ledger transactions and fixed bugs related to wallet interactions. > The following files were skipped due to too many changes: `yarn.lock` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`  Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

aaronmgdr added 2 commits December 3, 2024 13:28

create celoLegacy derivation alias,

1b8aaf2

import derivation info from celo base instead of thru cryptographic-utils

docs

0b74db2

aaronmgdr requested a review from a team as a code owner December 3, 2024 12:44

shazarre reviewed Dec 3, 2024

View reviewed changes

packages/cli/src/commands/account/new.ts Outdated Show resolved Hide resolved

Merge branch 'master' into aaronmgdr/derivation

ea41c03

nicolasbrugneaux reviewed Dec 3, 2024

View reviewed changes

packages/sdk/base/src/account.ts Outdated Show resolved Hide resolved

nicolasbrugneaux reviewed Dec 3, 2024

View reviewed changes

packages/cli/src/commands/account/new.ts Outdated Show resolved Hide resolved

aaronmgdr added 4 commits December 3, 2024 16:52

more tests, and ensure the path is valid bip44 or a valid named alias.

be15a7a

docs

c5f8377

warning

c64fac3

remove ledger live comment

0e61986

aaronmgdr requested review from shazarre and nicolasbrugneaux December 4, 2024 10:31

aaronmgdr commented Dec 4, 2024

View reviewed changes

aaronmgdr added 2 commits December 4, 2024 13:09

docs

620b1c9

nuke the lib folder so we never have any remaining stuff in it after …

f1bf01f

…cleaning run mainifest every time we build (this enables commands to be updated) since build already calls manifest dont need to call again in prepack

nicolasbrugneaux reviewed Dec 5, 2024

View reviewed changes

nicolasbrugneaux approved these changes Dec 5, 2024

View reviewed changes

shazarre reviewed Dec 5, 2024

View reviewed changes

aaronmgdr commented Dec 5, 2024

View reviewed changes

aaronmgdr added 2 commits December 6, 2024 10:13

the path is not full bip44 so make that clear

c3e9cd4

better handling of derivationPath flag

7b28cd2

aaronmgdr commented Dec 6, 2024

View reviewed changes

.changeset/nice-fireants-cheat.md Outdated Show resolved Hide resolved

Update .changeset/nice-fireants-cheat.md

a9a6a27

aaronmgdr commented Dec 6, 2024

View reviewed changes

.changeset/tasty-schools-reply.md Outdated Show resolved Hide resolved

Update .changeset/tasty-schools-reply.md

58ba32f

aaronmgdr commented Dec 6, 2024

View reviewed changes

packages/cli/src/commands/account/new.ts Outdated Show resolved Hide resolved

aaronmgdr added 2 commits December 6, 2024 12:22

Update packages/cli/src/commands/account/new.ts

83a7ae0

Merge branch 'master' into aaronmgdr/derivation

13bdb93

aaronmgdr enabled auto-merge (squash) December 6, 2024 11:25

aaronmgdr merged commit 26b9779 into master Dec 6, 2024
26 of 27 checks passed

aaronmgdr deleted the aaronmgdr/derivation branch December 6, 2024 11:33

github-actions bot mentioned this pull request Dec 6, 2024

Version Packages (beta) #478

Merged

github-actions bot mentioned this pull request Dec 11, 2024

Version Packages #485

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DerivationPath Alias #471

DerivationPath Alias #471

aaronmgdr commented Dec 3, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Dec 3, 2024 •

edited

Loading

codecov bot commented Dec 3, 2024 •

edited

Loading

aaronmgdr Dec 4, 2024

shazarre Dec 5, 2024

aaronmgdr commented Dec 4, 2024

nicolasbrugneaux Dec 5, 2024

shazarre Dec 5, 2024

aaronmgdr left a comment

gitguardian bot commented Dec 6, 2024 •

edited

Loading

DerivationPath Alias #471

DerivationPath Alias #471

Conversation

aaronmgdr commented Dec 3, 2024 • edited by pr-codex bot Loading

Description

Other changes

Related issues

PR-Codex overview

Detailed summary

changeset-bot bot commented Dec 3, 2024 • edited Loading

🦋 Changeset detected

codecov bot commented Dec 3, 2024 • edited Loading

Codecov Report

aaronmgdr Dec 4, 2024

Choose a reason for hiding this comment

shazarre Dec 5, 2024

Choose a reason for hiding this comment

aaronmgdr commented Dec 4, 2024

nicolasbrugneaux Dec 5, 2024

Choose a reason for hiding this comment

shazarre Dec 5, 2024

Choose a reason for hiding this comment

aaronmgdr left a comment

Choose a reason for hiding this comment

gitguardian bot commented Dec 6, 2024 • edited Loading

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

aaronmgdr commented Dec 3, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Dec 3, 2024 •

edited

Loading

codecov bot commented Dec 3, 2024 •

edited

Loading

gitguardian bot commented Dec 6, 2024 •

edited

Loading