remove force deaffiliate command

[aaronmgdr]

Description

This ancient command harkens back to the days pre celo mainnet when we were running a POA testnet.

It is not possible that this command is still usable as the method on the Validator Contract it calls forceDeaffiliateIfValidator has a onlySlasher modifier which check the caller against a set of slashers stored on LockedGold slashers are stored as keccak256(abi.encodePacked(slasherIdentifier)); which must point to an address in the registry. Therefore only slasher contracts can force deaffiliation.

modifier onlySlasher() {
    require(getLockedGold().isSlasher(msg.sender), "Only registered slasher can call");
    _;
  }

Other changes

add pre commands to docs generation to ensure it runs correctly each time.

upon running the now fixed docs commands the previously removed reserve commands were removed finally

see

https://github.com/celo-org/celo-monorepo/blob/faca88f6a48cc7c8e6104393e49ddf7c2d7d20e3/packages/protocol/contracts/governance/Validators.sol#L585

https://github.com/celo-org/celo-monorepo/blob/master/packages/protocol/contracts/governance/LockedGold.sol#L422

---

PR-Codex overview

This PR focuses on removing the celocli validator:force-deaffiliate command from the CLI, which was only usable before the mainnet launch. The documentation and related references have been updated to reflect this removal and provide alternative commands for managing validators.

Detailed summary

• Deleted docs/command-line-interface/reserve.md.
• Deleted packages/cli/src/commands/validator/force-deaffiliate.ts.
• Updated generate_docs.sh to remove documentation for the deleted command.
• Removed references to celocli validator:force-deaffiliate from docs/command-line-interface/validator.md.
• Added a note in the changeset about the removal of celocli validator:force-deaffiliate and provided alternative commands.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[changeset-bot]

🦋 Changeset detected

Latest commit: b7ef20a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@celo/celocli	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.01%. Comparing base (3890220) to head (b7ef20a).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   67.99%   68.01%   +0.01%     
==========================================
  Files         289      288       -1     
  Lines       10974    10960      -14     
  Branches     1568     1564       -4     
==========================================
- Hits         7462     7454       -8     
+ Misses       3453     3353     -100     
- Partials       59      153      +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[m-chrzan]

+12/-144

Love that. Looks good, just a question on reserve.md, whether removal was intentional or not.

[m-chrzan]

This was not mentioned in the PR description - why are these docs getting removed? Have these commands been previously deleted and we forgot to remove the docs then?

[aaronmgdr]

good call, updated description. yes the reserve commands were removed previously