-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Mark methods that are L1only as deprecated (#455)
### Description went thru https://github.com/celo-org/celo-monorepo/tree/release/core-contracts/12/packages and marked methdods that have onlyL1 modifier that are called in contactkit as deprecated. ### Related issues - Fixes [#458](#458) <!-- start pr-codex --> --- ## PR-Codex overview This PR primarily focuses on marking various contract wrapper methods as deprecated, indicating they will be removed in the future. It also includes a note on the transition to L2, where certain methods will no longer function. ### Detailed summary - Marked `GasPriceMinimumWrapper`, `BlockchainParametersWrapper`, and `DoubleSigningSlasherWrapper` as deprecated. - Added deprecation notes for methods in `ValidatorsWrapper` and `ElectionWrapper`. - Updated documentation to reflect deprecated status and replacements for several methods. - Indicated that `blsPublicKey` is no longer used. - Specified that contracts will be removed as per the provided links. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
- Loading branch information
Showing
25 changed files
with
229 additions
and
117 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
--- | ||
'@celo/contractkit': patch | ||
--- | ||
|
||
Mark contract wrapper methods that will not work on L2 because solidity contracts have onlyL1 modifier as deprecated. | ||
|
||
| Deprecated Contract / Method | Replacement or none | | ||
|--------|--------| | ||
| Validators#registerValidator | Validators#registerValidatorNoBLS | | ||
| BlockchainParams#getEpochNumberOfBlock | EpochManager#getEpochNumberOfBlock | | ||
| BlockchainParams#getFirstBlockNumberForEpoch | EpochManager#getFirstBlockAtEpoch| | ||
| Election#getCurrentValidatorSigners | EpochManager#getElectedSigners | | ||
| Election#getGroupEpochRewards | Election#getGroupEpochRewardsBasedOnScore | | ||
| GovernanceSlasher#slash | GovernanceSlasher#slashL2 | | ||
| DoubleSigningSlasher | X | | ||
| DowntimeSlasher | X | | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.