L2 coverage

[shazarre]

Description

Based on an internal audit we discovered some commands that were not L2 compatible. In an effort to increase code coverage and discover potential issues many commands were covered by additional L2 tests:

• account
• election
• governance
• lockedgold
• releasecelo
• validator
• validatorgroup

That ensures that most of the commands are L2-ready.

Other changes

Test utils were adapted to work with new devchain in L2 context (for example epoch related utils).

Tested

Ran tests locally and on CI.

Related issues

Fixes #406

Follow up issues for potentially non-trivial changes:

• celocli validator: view command fixes #416
• celocli rewards:show fix for L2 #415
• celocli governance:show update #414
• celocli governance:build-proposal command fixes L2 #413
• celocli account:authorize #417

---

PR-Codex overview

This PR introduces enhancements for L2 support in the Celo ecosystem, particularly focusing on validator registration and governance functionalities, while deprecating BLS key requirements.

Detailed summary

• Added registerValidatorNoBls method to ValidatorsWrapper for L2 registration without BLS keys.
• Updated validator:register command to make BLS keys optional.
• Modified tests and commands to support L2 functionalities.
• Updated documentation to reflect changes in validator registration and governance commands.

The following files were skipped due to too many changes: packages/cli/src/commands/releasecelo/show-l2.test.ts, packages/cli/src/commands/releasecelo/transfer-dollars-l2.test.ts, packages/cli/src/commands/governance/dequeue-l2.test.ts, packages/cli/src/commands/governance/test-proposal-l2.test.ts, packages/cli/src/commands/governance/upvote-l2.test.ts, packages/cli/src/commands/election/revoke-l2.test.ts, packages/cli/src/commands/governance/hashhotfix-l2.test.ts, packages/cli/src/commands/releasecelo/set-beneficiary-l2.test.ts, packages/cli/src/commands/election/vote-l2.test.ts, packages/cli/src/commands/validatorgroup/deregister.test.ts, packages/cli/src/commands/governance/show-l2.test.ts, packages/cli/src/commands/election/run-l2.test.ts, packages/cli/src/commands/election/show-l2.test.ts, packages/cli/src/commands/validator/list.test.ts, packages/cli/src/commands/releasecelo/withdraw-l2.test.ts, packages/cli/src/commands/election/current-l2.test.ts, packages/cli/src/commands/election/activate-l2.test.ts, packages/cli/src/commands/governance/execute-l2.test.ts, packages/cli/src/commands/account/authorize-l2.test.ts, packages/cli/src/commands/releasecelo/authorize-l2.test.ts, packages/cli/src/commands/validator/deregister.test.ts, packages/cli/src/commands/releasecelo/admin-revoke-l2.test.ts, docs/sdk/contractkit/classes/wrappers_Validators.ValidatorsWrapper.md, packages/cli/src/commands/governance/propose-l2.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[changeset-bot]

⚠️ No Changeset found

Latest commit: 1e04233

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.29%. Comparing base (23d36cc) to head (1e04233).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   68.01%   70.29%   +2.28%     
==========================================
  Files         288      288              
  Lines       10960    10978      +18     
  Branches     1563     1567       +4     
==========================================
+ Hits         7454     7717     +263     
+ Misses       3430     3187     -243     
+ Partials       76       74       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aaronmgdr]

shipshape

[aaronmgdr]

merged already 76045eb