Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port fixes from l2 investigation back. allow a validator reg without bls #418

Closed
wants to merge 2 commits into from

Conversation

aaronmgdr
Copy link
Member

@aaronmgdr aaronmgdr commented Nov 5, 2024

Description

removed bls requirement for validator registration

Other changes

mark force-deaffiliate as deprecated.

Tested

Related issues

inspired by #401


PR-Codex overview

This PR focuses on deprecating the validator:force-deaffiliate command and updating the validator registration process to allow registration without a BLS key. It also modifies the command-line interface and the related code to reflect these changes.

Detailed summary

  • Deprecated validator:force-deaffiliate command.
  • Updated registerValidatorNoBls method in Validators.ts.
  • Modified command-line interface for validator:register to make BLS keys optional.
  • Adjusted ValidatorRegister class to handle registration without BLS keys.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: 569119a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@celo/celocli Patch
@celo/contractkit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.29%. Comparing base (ce7cfa8) to head (569119a).
Report is 3 commits behind head on hotfixes.

Files with missing lines Patch % Lines
packages/cli/src/commands/validator/register.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           hotfixes     #418   +/-   ##
=========================================
  Coverage     67.28%   67.29%           
=========================================
  Files           294      294           
  Lines         10941    10945    +4     
  Branches       1561     1557    -4     
=========================================
+ Hits           7362     7365    +3     
- Misses         3416     3447   +31     
+ Partials        163      133   -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aaronmgdr aaronmgdr closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant