Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L2 coverage #401

Closed
wants to merge 42 commits into from
Closed
Show file tree
Hide file tree
Changes from 39 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
e29fc4f
L2 coverage
shazarre Oct 22, 2024
cbfde6e
L2 logic for registering a validator for chain setup in tests
shazarre Oct 22, 2024
558e614
adapt election:activate L2 tests to new epochs
shazarre Oct 22, 2024
2a4db7a
L2 check for automated voting/activating test setup
shazarre Oct 22, 2024
1357baa
fix broken L1 tests
shazarre Oct 22, 2024
1d9840e
temp: mark failing test explicitly
shazarre Oct 23, 2024
16cf6c8
governance L2 tests
shazarre Oct 23, 2024
dcf3854
add tests for validatorgroup commands
aaronmgdr Oct 28, 2024
91e9db9
Tests for Validators
aaronmgdr Oct 29, 2024
8ba1cdf
more validator tests
aaronmgdr Oct 29, 2024
a66a70e
add test for vg deregister
aaronmgdr Oct 30, 2024
ff51d94
governance:dequeue L2 coverage
shazarre Oct 31, 2024
1932fb8
governance:hashhotfix L2 coverage
shazarre Oct 31, 2024
882be3c
happy path test for governance:execute L2
shazarre Oct 31, 2024
2eeb1a1
add affiliation tests
aaronmgdr Oct 31, 2024
9639185
basic "governance:show" test
shazarre Oct 31, 2024
c2e3954
Merge branch 'shazarre/L2_coverage' of github.com:celo-org/developer-…
shazarre Oct 31, 2024
037a9da
governance:test-proposal L2 coverage
shazarre Nov 4, 2024
5fd376d
allow validate register without bls keys
aaronmgdr Nov 4, 2024
aed0c3f
add test for deregister validator and validator group member
aaronmgdr Nov 4, 2024
6f221e7
multiplier test
aaronmgdr Nov 4, 2024
bf42766
governance:revokeupvote L2 coverage
shazarre Nov 5, 2024
851530d
Merge branch 'shazarre/L2_coverage' of github.com:celo-org/developer-…
shazarre Nov 5, 2024
1ff9014
remove test for not supported method
shazarre Nov 5, 2024
b9e4a87
Merge branch 'master' into shazarre/L2_coverage
shazarre Nov 5, 2024
90808da
Throw error when using BLS for releasecelo:authorize in L2
shazarre Nov 5, 2024
68dcf67
explicit releasecelo command L2 coverage
shazarre Nov 5, 2024
cab0232
releasegold:create-account coverage
shazarre Nov 5, 2024
de1abec
releasecelo:set-account + releasecelo:set-can-expire L2 coverage
shazarre Nov 5, 2024
0e3e9e9
fix governance tests so they can run in parallel
shazarre Nov 5, 2024
3143d43
releasecelo: L2 coverage for set-liquidity-provision, set-max-distrib…
shazarre Nov 5, 2024
9e681e5
fix tests and wonder how they passed. ms vs seconds.
aaronmgdr Nov 5, 2024
df39ecb
Merge branch 'shazarre/L2_coverage' of https://github.com/celo-org/de…
aaronmgdr Nov 5, 2024
8e7ae7f
docs
shazarre Nov 6, 2024
2f73185
need a longer timeout
aaronmgdr Nov 6, 2024
424f02e
make it more obvious
shazarre Nov 6, 2024
05a95ce
contractkit changeset
shazarre Nov 6, 2024
63f6aa3
celocli changeset
shazarre Nov 6, 2024
6dff63e
CR fixes
shazarre Nov 6, 2024
9feb906
no more mocking for election:show L2 tests
shazarre Nov 6, 2024
60414d0
CR fixes
shazarre Nov 6, 2024
1e04233
Merge branch 'master' into shazarre/L2_coverage
shazarre Nov 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/smart-berries-accept.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@celo/contractkit': minor
---

ValidatorsWrapper: add registerValidatorNoBls to allow registration without BLS keys which are not supported in L2
5 changes: 5 additions & 0 deletions .changeset/twenty-rocks-pull.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@celo/celocli': minor
---

BLS keys are now optional as being deprecated on L2, validator:register and releasecelo:authorize no longer require them in L2 context
9 changes: 4 additions & 5 deletions docs/command-line-interface/validator.md
Original file line number Diff line number Diff line change
Expand Up @@ -224,13 +224,12 @@ Register a new Validator
```
USAGE
$ celocli validator:register --from 0xc1912fEE45d61C87Cc5EA59DaE31190FFFFf232d
--ecdsaKey 0x --blsKey 0x --blsSignature 0x [--gasCurrency
0x1234567890123456789012345678901234567890] [--globalHelp] [--yes]
--ecdsaKey 0x [--gasCurrency 0x1234567890123456789012345678901234567890]
[--globalHelp] [--blsKey 0x] [--blsSignature 0x] [--yes]

FLAGS
--blsKey=0x (required) BLS Public Key
--blsSignature=0x (required) BLS
Proof-of-Possession
--blsKey=0x BLS Public Key
--blsSignature=0x BLS Proof-of-Possession
--ecdsaKey=0x (required) ECDSA Public Key
--from=0xc1912fEE45d61C87Cc5EA59DaE31190FFFFf232d (required) Address for the
Validator
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ Contract for voting for validators and managing validator groups.
- [isValidatorGroup](wrappers_Validators.ValidatorsWrapper.md#isvalidatorgroup)
- [methodIds](wrappers_Validators.ValidatorsWrapper.md#methodids)
- [registerValidator](wrappers_Validators.ValidatorsWrapper.md#registervalidator)
- [registerValidatorNoBls](wrappers_Validators.ValidatorsWrapper.md#registervalidatornobls)
- [removeMember](wrappers_Validators.ValidatorsWrapper.md#removemember)
- [resetSlashingMultiplier](wrappers_Validators.ValidatorsWrapper.md#resetslashingmultiplier)
- [setNextCommissionUpdate](wrappers_Validators.ValidatorsWrapper.md#setnextcommissionupdate)
Expand Down Expand Up @@ -140,7 +141,7 @@ De-affiliates with the previously affiliated group if present.

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:487](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L487)
[packages/sdk/contractkit/src/wrappers/Validators.ts:493](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L493)

___

Expand Down Expand Up @@ -170,7 +171,7 @@ Fails if the account is not a validator with non-zero affiliation.

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:497](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L497)
[packages/sdk/contractkit/src/wrappers/Validators.ts:503](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L503)

___

Expand Down Expand Up @@ -259,7 +260,7 @@ Removes a validator from the group for which it is a member.

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:503](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L503)
[packages/sdk/contractkit/src/wrappers/Validators.ts:509](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L509)

___

Expand Down Expand Up @@ -369,7 +370,7 @@ ___

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:436](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L436)
[packages/sdk/contractkit/src/wrappers/Validators.ts:442](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L442)

___

Expand All @@ -393,7 +394,7 @@ ___

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:438](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L438)
[packages/sdk/contractkit/src/wrappers/Validators.ts:444](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L444)

___

Expand Down Expand Up @@ -678,6 +679,30 @@ Fails if the account is already a validator or validator group.

___

### registerValidatorNoBls

• **registerValidatorNoBls**: (`ecdsaPublicKey`: `string`) => `CeloTransactionObject`\<`boolean`\>

#### Type declaration

▸ (`ecdsaPublicKey`): `CeloTransactionObject`\<`boolean`\>

##### Parameters

| Name | Type |
| :------ | :------ |
| `ecdsaPublicKey` | `string` |

##### Returns

`CeloTransactionObject`\<`boolean`\>

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:436](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L436)

___

### removeMember

• **removeMember**: (...`args`: [validator: string]) => `CeloTransactionObject`\<`boolean`\>
Expand Down Expand Up @@ -708,7 +733,7 @@ The ValidatorGroup is specified by the `from` of the tx.

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:544](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L544)
[packages/sdk/contractkit/src/wrappers/Validators.ts:550](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L550)

___

Expand Down Expand Up @@ -738,7 +763,7 @@ the last time the group was slashed.

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:512](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L512)
[packages/sdk/contractkit/src/wrappers/Validators.ts:518](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L518)

___

Expand Down Expand Up @@ -878,7 +903,7 @@ Fails if `validator` has not set their affiliation to this account.

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:522](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L522)
[packages/sdk/contractkit/src/wrappers/Validators.ts:528](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L528)

___

Expand All @@ -894,7 +919,7 @@ Returns the current set of validator signer addresses

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:637](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L637)
[packages/sdk/contractkit/src/wrappers/Validators.ts:643](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L643)

___

Expand All @@ -910,7 +935,7 @@ Returns the current set of validator signer and account addresses

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:647](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L647)
[packages/sdk/contractkit/src/wrappers/Validators.ts:653](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L653)

___

Expand All @@ -932,7 +957,7 @@ De-registers a validator, removing it from the group for which it is a member.

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:444](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L444)
[packages/sdk/contractkit/src/wrappers/Validators.ts:450](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L450)

___

Expand All @@ -954,7 +979,7 @@ De-registers a validator Group

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:472](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L472)
[packages/sdk/contractkit/src/wrappers/Validators.ts:478](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L478)

___

Expand All @@ -979,7 +1004,7 @@ Index for epoch or -1.

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:680](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L680)
[packages/sdk/contractkit/src/wrappers/Validators.ts:686](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L686)

___

Expand Down Expand Up @@ -1015,7 +1040,7 @@ ___

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:594](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L594)
[packages/sdk/contractkit/src/wrappers/Validators.ts:600](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L600)

___

Expand All @@ -1029,7 +1054,7 @@ ___

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:582](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L582)
[packages/sdk/contractkit/src/wrappers/Validators.ts:588](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L588)

___

Expand Down Expand Up @@ -1087,7 +1112,7 @@ ___

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:588](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L588)
[packages/sdk/contractkit/src/wrappers/Validators.ts:594](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L594)

___

Expand Down Expand Up @@ -1285,7 +1310,7 @@ Group and membership history index for `validator`.

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:661](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L661)
[packages/sdk/contractkit/src/wrappers/Validators.ts:667](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L667)

___

Expand All @@ -1308,7 +1333,7 @@ Retrieves ValidatorRewards for epochNumber.

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:604](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L604)
[packages/sdk/contractkit/src/wrappers/Validators.ts:610](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L610)

___

Expand Down Expand Up @@ -1400,7 +1425,7 @@ Fails if the account does not have sufficient weight.

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:461](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L461)
[packages/sdk/contractkit/src/wrappers/Validators.ts:467](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L467)

___

Expand All @@ -1425,7 +1450,7 @@ Fails if `validator` is not a member of the account's validator group.

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:553](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L553)
[packages/sdk/contractkit/src/wrappers/Validators.ts:559](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L559)

___

Expand Down
2 changes: 1 addition & 1 deletion docs/sdk/contractkit/modules/wrappers_Validators.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@

#### Defined in

[packages/sdk/contractkit/src/wrappers/Validators.ts:689](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L689)
[packages/sdk/contractkit/src/wrappers/Validators.ts:695](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/contractkit/src/wrappers/Validators.ts#L695)
Loading
Loading