fix: set component styles again #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This is the way! |
sgoudham
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Thanks for this! It definitely wasn't intentional to display less information.
I don't personally use this application but I think the choices you've made are sensible - I'll get around to trying it afterwards and see if improvements can be made but happy to merge for now!
sgoudham
changed the title
|
i just realized that the preview images are now out of date since the theme looks slightly different (the playback metadata is missing in the screenshots, compare them to the one posted in this pr's comments). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr re-adds the additions of #1 which were removed in #6.
i've also added the other options from the available component styles, trying to provide sensible options if needed; suggestions about color changes are very welcome.
closes #11 since nothing except the background is set to
BrightBlack:playback_metadataandplayback_progress_barare set according to the changes in Set components styles explicitly #1playlist_descis set tosubtext0since i found that to fit well