Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(home-manager): add support for spotify-player #296

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

w-lfchen
Copy link
Contributor

I have an issue with the theme:
The playback_metadata component has the same color as the background and is therefore not legible.
But this should be fixed in the catppuccin repo, right?

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also add a new entry to tests/home.nix enabling the module

But this should be fixed in the catppuccin repo, right?

And yep!

modules/home-manager/spotify-player.nix Outdated Show resolved Hide resolved
@w-lfchen
Copy link
Contributor Author

w-lfchen commented Aug 15, 2024

didn't mean to make the ci status disappear by updating the branch ^^'
here are the results of the run:
https://github.com/catppuccin/nix/actions/runs/10280254042
i've also opened catppuccin/spotify-player#12; in case that pr gets merged, do i have to request an update or does that happen automatically?
update: it got merged, i've updated the sources

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@getchoo getchoo merged commit ff4128f into catppuccin:main Aug 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants