feat(QTM-730): Avoiding forwarding no-gutters props to children other than Row and Container to avoid #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in component props instead of
…up components to avoid warnings
…lass-properties plugins from ba
build(.nvmrc): Updated node version to 20.15.0
perf(QTM-708): Lint adjustment to check definition of defaultParams in component props instead of defaultProps
build(package.json): Removing transform-modern-regexp and transform-class-properties
… actions/setup-node to latest v
ci(QTM-666): Updated actions/checkout and setup-node to node v20 support
feat(JAS-4013): add new icon to Cathoflix category
feat: Updates Contributing.md
… not available via cursor
Co-authored-by: MarcosViniciusPC <[email protected]>
Co-authored-by: MarcosViniciusPC <[email protected]>
Co-authored-by: MarcosViniciusPC <[email protected]>
feat: adding new icon (DescriptionOutlinedIcon)
fix(AutoComplete.jsx): Preventing auto complete from set a suggestion…
…than Row and Container to avoid
|
alizeleal
added
status:reviewing
alizeleal
approved these changes
Sep 6, 2024
alizeleal
added
status:approved
status:suggestion
and removed
status:reviewing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://jirasoftware.catho.com.br/browse/QTM-730
Review guide
How to test
In the HorizontalExample in stories/Grid/Grid.jsx, add the no-gutters prop to the Row component
Run the storybook (yarn storybook) and check for any warnings in the terminal and browser console. The expected result is to have no warnings related to no-gutters prop
How to test on SSR