Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AutoComplete.jsx): Preventing auto complete from set a suggestion… #580

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

MarcosViniciusPC
Copy link
Contributor

@MarcosViniciusPC MarcosViniciusPC commented Aug 28, 2024

Description

https://jirasoftware.catho.com.br/browse/QTM-775

Review guide

How to test

  • Run the storybook and select the AutoComplete component
  • Inspect the page and select the Console tab
  • Type the text "Moran" and wait for the list of suggestions to open, but do not select any item.
  • Press the "Tab" key to change the input focus.
  • Now press "Shift + Tab" to return focus to the input (When returning focus to the input, the text must be selected)
  • Now click on the input with the mouse.
  • If no warnings are displayed in the console, then the fixes worked.

Note: Following this step by step, in the master branch, several warnings are triggered in the console.

How to test in the application

  • On quantum, run yarn && yarn build
  • Now clone the project https://github.com/catho/recruiter-experience_company-registration_app. (ENVs sent via Secure Password (https://ssaws.catho.vs/). Go to the "My Safe" page => "Passwords" and search for "ENV Recruiter Experience Company Registration"
    )
  • Add the local quandum build to the cloned project using the yarn add ../quantum/dist command
  • Run the application using yarn dev
  • On the opened page, focus on AutoComplete just by using the Tab key.
  • In autocomplete, type "Develop", wait for the list of suggestions to open, but do not select any option.
  • Now press "Tab". If the application doesn't crash, the fix worked.

Copy link

@alizeleal alizeleal added status:approved and removed status:reviewing Someone is reviewing this PR labels Aug 30, 2024
@MarcosViniciusPC MarcosViniciusPC merged commit c246b23 into master Sep 2, 2024
3 checks passed
Copy link

github-actions bot commented Sep 2, 2024

🎉 This PR is included in version 9.31.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MarcosViniciusPC MarcosViniciusPC deleted the QTM-775 branch October 9, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants