Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(JAS-4013): add new icon to Cathoflix category #578

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

carolnog
Copy link
Contributor

@carolnog carolnog commented Aug 21, 2024

Description

Put the description of the task here.
JAS-4013

Setup

to view the components behavior, run yarn storybook

Review guide

  • Coverage (coverage status should not regress)
    - yarn test:coverage
  • Unit tests (yarn test:components)
  • Regression
    - first start the storybook for regression tests(and keep it open): yarn test:regression:storybook;
    - then run the regression tests: yarn test:regression
  • Code review
  • TypeScript updated

A11y review

  • A11y checks
    • accessible via keyboard?
    • Identifiable through assistive technology (screen-reader chrome extension)?
    • Semantically correct html elements (or if necessary identified by WAI-ARIA)?
    • Is there a deficiency in color contrast?

Browsers review

  • Layout review
    • Edge
    • Firefox
    • Chrome
    • Safari
    • Mobile
  • Ux review validation

Copy link
Contributor

@MarcosViniciusPC MarcosViniciusPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[x] Code review
[x] Doc

@MarcosViniciusPC MarcosViniciusPC added status:pending review and removed status:reviewing Someone is reviewing this PR labels Aug 22, 2024
Copy link
Contributor

@alizeleal alizeleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Unit tests (yarn test:components)
  • Regression tests
  • Code review

@alizeleal alizeleal self-assigned this Aug 22, 2024
@alizeleal alizeleal merged commit b7973cd into master Aug 22, 2024
2 checks passed
Copy link

🎉 This PR is included in version 9.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MarcosViniciusPC MarcosViniciusPC deleted the JAS-4013 branch October 9, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants