Allow *.orion.pb.go files to access the exported-service-desc from *.pb.go #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pb.go Add two execution parameters. standalone-mode: Allow you to place *.orion.pb.go and *.pb.go into different folder. exported-service-desc: Allow you to use the higher version (v1.20.0) of protoc-gen-go. Read go_package option from protobufs files. In standalone mode, the external import path is getting from the go_package option.
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
=======================================
Coverage 57.97% 57.97%
=======================================
Files 13 13
Lines 564 564
=======================================
Hits 327 327
Misses 230 230
Partials 7 7 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
benjaminheng
previously approved these changes
Sep 22, 2022
benjaminheng
approved these changes
Sep 22, 2022
|
|
||
| import "google.golang.org/grpc" | ||
|
|
||
| var ExampleService_ServiceDesc grpc.ServiceDesc |
There was a problem hiding this comment.
@cs-lexliu Can you add this variable generated from protoc-gen-go
Which version of protoc-gen-go should be used to generate it?
because current version would generate _ExampleService_ServiceDesc.
Do we have to bump the version in shared-proto scripts?
There was a problem hiding this comment.
Let me create another PR to describe how to use the tool and supported grpc version for the tool
praveensanap
approved these changes
Sep 26, 2022
cs-lexliu
deleted the
186-support-exported-service-desc-without-refactoring
branch
This was referenced Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two execution parameters.
standalone-mode: Allow you to place *.orion.pb.go and *.pb.go into different folder.exported-service-desc: Allow you to use the higher version (v1.20.0) of protoc-gen-go. Read go_package option from protobufs files.In standalone mode, the external import path is getting from the go_package option.
Check protoc-gen-orion/testprotos/Makefile for the usage.
#186