Add protoc-gen-orion usage into readme #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #190 +/- ##
===========================================
- Coverage 57.97% 43.88% -14.10%
===========================================
Files 13 6 -7
Lines 564 319 -245
===========================================
- Hits 327 140 -187
+ Misses 230 176 -54
+ Partials 7 3 -4 ☔ View full report in Codecov by Sentry. |
achichen
reviewed
Sep 28, 2022
README.md
Outdated
| 3. The [sample](https://github.com/carousell/Orion/blob/master/protoc-gen-orion/testprotos/example/example.proto.orion.pb.go) of the result after you execute the command. | ||
|
|
||
| #### For version of `protoc-gen-go` higher and equal than v1.20.0. | ||
| You should enable the **exported-service-desc** flag to get the correct service description. |
There was a problem hiding this comment.
is this a "must" or just "should"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce the new features in #189. Add a usage into readme to explain how to use the tool.