Allow *.orion.pb.go files to access the exported-service-desc from *.pb.go #187
Conversation
The generate method has a side-effect on input data. Add a return value for generate method to prevent the data to be changed within the method.
Decouple the dependency between generator logic and proto lib.
Create a new generator package to make the logic can be reuse by other main function.
rename orion.go to main.go, main is a standard name for the main function files.
…pb.go Add two execution parameters. `standalone-mode`: Allow you to place *.orion.pb.go and *.pb.go into different folder. `exported-service-desc`: Allow you to use the higher version (v1.20.0) of protoc-gen-go. Read go_package option from protobufs files. In standalone mode, the external import path is getting from the go_package option.
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
=======================================
Coverage 58.49% 58.49%
=======================================
Files 13 13
Lines 559 559
=======================================
Hits 327 327
Misses 225 225
Partials 7 7 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -0,0 +1,122 @@ | |||
| package inputs | |||
There was a problem hiding this comment.
The inputs package decouples the dependency of protobuf library from internal logic.
| @@ -0,0 +1,82 @@ | |||
| module github.com/carousell/Orion/protoc-gen-orion/internal/testprotos | |||
There was a problem hiding this comment.
Introduce a internal/testprotos sub-module for isolating the github.com/carousell/Orion dependency.
With this file, protoc-gen-orion wouldn't need to depend on github.com/carousell/Orion.
| // | ||
| // The generated code is documented in the package comment for | ||
| // the library. | ||
| package main |
There was a problem hiding this comment.
keep the main function in protoc-gen-orion/main.go. And move the generating logic into internal/generator/generator.go file.
|
I'll review it soon. I expected only a few changes to add the flag handling. The large refactor means I'll need to set aside a larger block of time, which I don't have yet. |
|
The feature is implemented in another PR without the refactoring. |
Allow *.orion.pb.go files to access the exported-service-desc from *.pb.go
Add two execution parameters.
standalone-mode: Allow you to place *.orion.pb.go and *.pb.go into different folder.exported-service-desc: Allow you to use the higher version (v1.20.0) of protoc-gen-go.Read go_package option from protobufs files.
In standalone mode, the external import path is getting from the go_package option.
#186