Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caniuse warning in yarn.lock #1289

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

rphair
Copy link
Collaborator

@rphair rphair commented Aug 6, 2024

Local builds have been showing this warning message for a long time in yarn build:

Browserslist: caniuse-lite is outdated. Please run:
  npx update-browserslist-db@latest
  Why you should do it regularly: https://github.com/browserslist/update-db#readme

We have to keep caniuse up to date to avoid loading features into the browser (as polyfills) which have become supported by browsers in the meantime.

I held off on this waiting for #1157 but with attention to yarn.lock (#1288) plus traffic for the newly homed node documentation (#1287) I thought we had best ensure the browser environment runs efficiently & avoid confusing contributors with the warning that could lead to unnecessary modifications of yarn.lock.

Builds OK & runs well in (at least in my own) browser in my local environment ✅

@rphair rphair added the bug Something isn't working label Aug 6, 2024
@rphair
Copy link
Collaborator Author

rphair commented Aug 6, 2024

p.s. the diff isn't showing for me here on GitHub (the "large diff" message, with an error if you try to display the diff); here is the locally running diff which shows the specific changes (only caniuse and a dependent package):

$ git diff
diff --git a/yarn.lock b/yarn.lock
index c8eb062..712749e 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -4200,9 +4200,9 @@ __metadata:
   linkType: hard
 
 "caniuse-lite@npm:^1.0.0, caniuse-lite@npm:^1.0.30001449, caniuse-lite@npm:^1.0.30001464":
-  version: 1.0.30001486
-  resolution: "caniuse-lite@npm:1.0.30001486"
-  checksum: 5e8c2ba2679e4ad17dea6d2761a6449b814441bfeac81af6cc9d58af187df6af4b79b27befcbfc4a557e720b21c0399a7d1911c8705922e38938dcc0f40b5d4b
+  version: 1.0.30001649
+  resolution: "caniuse-lite@npm:1.0.30001649"
+  checksum: 7952512a243f22c942e0e99249def19d781ad1900db101f2d8de9d83de37db000a7dc7f226c9c99134001975e22852becf1677539c24c7ecae53467b681c400f
   languageName: node
   linkType: hard
 
@@ -10792,11 +10792,11 @@ __metadata:
 
 "typescript@patch:typescript@^4.5.3#~builtin<compat/typescript>":
   version: 4.9.5
-  resolution: "typescript@patch:typescript@npm%3A4.9.5#~builtin<compat/typescript>::version=4.9.5&hash=289587"
+  resolution: "typescript@patch:typescript@npm%3A4.9.5#~builtin<compat/typescript>::version=4.9.5&hash=ad5954"
   bin:
     tsc: bin/tsc
     tsserver: bin/tsserver
-  checksum: 1f8f3b6aaea19f0f67cba79057674ba580438a7db55057eb89cc06950483c5d632115c14077f6663ea76fd09fce3c190e6414bb98582ec80aa5a4eaf345d5b68
+  checksum: 8f6260acc86b56bfdda6004bc53f32ea548f543e8baef7071c8e34d29d292f3e375c8416556c8de10b24deef6933cd1c16a8233dc84a3dd43a13a13265d0faab
   languageName: node
   linkType: hard

@katomm katomm force-pushed the fix-caniuse-warning branch from 7d2ced6 to 6310140 Compare August 28, 2024 09:46
@katomm katomm merged commit 6dc2413 into cardano-foundation:staging Aug 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants