-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Upgrade to Docusaurus 3 #1157
[WIP] Upgrade to Docusaurus 3 #1157
Conversation
Hey Clark, great to see you. Can we briefly discuss beforehand if we want to go through another beta update hell with the portal and have constant UI and other breaking changes likely? |
for sure, thats why this is just a draft to start that process, infact we can merge this PR once v3 is released to ensure stability and just keep track of the beta and make sure the portal is ready for the release |
Docusaurus 3.0 RC is out facebook/docusaurus#9429 it felt like the beta had just launched. |
Let's goo, time get my hands dirty 😅. Will check what compatibility issues needs to be fixed |
After looking further, heres a list of compatiblity issues I've found so far.
#### Calculate the change to send back to `payment.addr`
All amounts must be in Lovelace:
expr <UTXO BALANCE> - <AMOUNT TO SEND> - <TRANSACTION FEE> The parser thinks it Could be a good oppurtunity to rewrite the CIP into a blog content plugin-aswell. That way we can display the authors much more clearly since the blog already has support for that. P.S this is by no means a comprehensive list of compatiblity issues |
@Mercurial @katomm if we could suppress the interpretation of opening tags it would be a big help to the CIP process. As it is now, we've had to make more changes like these to stop headers from being wiped out after the first
... which has been OK so far, since we've cleaned up the formatting of code segments used as document headers, but over time would have to enforce this in every bit of pseudocode like the above... which would be a full-time job. 😰 |
@fill-the-fill could you please look into the points that @Mercurial raised above? |
@katomm @Mercurial it's out of RC! 🤓 Just seen tonight in local build: |
@fill-the-fill or @Mercurial did not answer yet, so clever to put this on hold for now. (In particular before Christmas) |
@katomm @fill-the-fill @Mercurial newer version ready now 🤠🚀
|
@fill-the-fill, six months passed, any opinion on this? Thanks |
Hate to be the guy, but can we please get an answer here @fill-the-fill |
another advantage to upgrading: to fix some outdated packages likely not reconcilable with the current Docusaurus version's package configuration, e.g. (observable in local build):
|
Fixed it in #1335 |
I think it's OK to close this since we have a working build in the other PR (all that remains to be fixed are build warnings & apparently some artefacts from content reformatting: since many reported errors aren't in the source material). @Mercurial I hope you can double-check my last #1335 (review) & my hypothesis about what the problem might be. |
No description provided.