PR template - add yarn.lock advisement
#1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphair
requested review from
rdlrt,
katomm,
fill-the-fill,
os11k,
gufmar and
gitmachtl
rdlrt
approved these changes
Aug 6, 2024
gitmachtl
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by recent discussion in #1286 (comment) / #1286 (comment).
Most
yarn.lockissues have to be dealt with after the fact and we see it more often than not with new contributors. Therefore this should help to reduce workload by not having to coordinate removingyarn.lockwith contributors repeatedly, while assuring a more focused contributor / editor workload on the Portal.The language is key of course, so as not to call too much attention to a problem that contributors might not have (a justification for keeping it brief, and for keeping the detailed instructions parenthetical)... so feedback about the wording is welcome.
How this currently appears (the last Checklist item in all 3 cases):
yarn.lock(or have removed these changes).