-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error handling in restore benchmark #2568
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put TMPDIR in /scratch/tmp so that there's always enough space. Ensure that the node database path is set. It can also be cached between runs.
rvl
force-pushed
the
rvl/adp-804/fix-restore-bench
branch
from
March 18, 2021 09:14
83f29a1
to
3fed76f
Compare
piotr-iohk
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 23, 2021
2568: Better error handling in restore benchmark r=rvl a=rvl ### Issue Number ADP-804 ### Overview - Handle case where node exits before restore bench is finished. - Fix disk space error. ### Comments [Buildkite nightly builds](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds?branch=rvl/adp-804/fix-restore-bench) The restore benchmark no longer fails from the original error. It now seems to reach the 10 hour timeout on mainnet. So the benchmark wallets need to be made smaller... in another PR. Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed:
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 23, 2021
2568: Better error handling in restore benchmark r=Anviking a=rvl ### Issue Number ADP-804 ### Overview - Handle case where node exits before restore bench is finished. - Fix disk space error. ### Comments [Buildkite nightly builds](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds?branch=rvl/adp-804/fix-restore-bench) The restore benchmark no longer fails from the original error. It now seems to reach the 10 hour timeout on mainnet. So the benchmark wallets need to be made smaller... in another PR. Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed:
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 23, 2021
2568: Better error handling in restore benchmark r=Anviking a=rvl ### Issue Number ADP-804 ### Overview - Handle case where node exits before restore bench is finished. - Fix disk space error. ### Comments [Buildkite nightly builds](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds?branch=rvl/adp-804/fix-restore-bench) The restore benchmark no longer fails from the original error. It now seems to reach the 10 hour timeout on mainnet. So the benchmark wallets need to be made smaller... in another PR. Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed:
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 23, 2021
2568: Better error handling in restore benchmark r=Anviking a=rvl ### Issue Number ADP-804 ### Overview - Handle case where node exits before restore bench is finished. - Fix disk space error. ### Comments [Buildkite nightly builds](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds?branch=rvl/adp-804/fix-restore-bench) The restore benchmark no longer fails from the original error. It now seems to reach the 10 hour timeout on mainnet. So the benchmark wallets need to be made smaller... in another PR. Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed:
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 23, 2021
2568: Better error handling in restore benchmark r=Anviking a=rvl ### Issue Number ADP-804 ### Overview - Handle case where node exits before restore bench is finished. - Fix disk space error. ### Comments [Buildkite nightly builds](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds?branch=rvl/adp-804/fix-restore-bench) The restore benchmark no longer fails from the original error. It now seems to reach the 10 hour timeout on mainnet. So the benchmark wallets need to be made smaller... in another PR. Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed:
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 23, 2021
2568: Better error handling in restore benchmark r=Anviking a=rvl ### Issue Number ADP-804 ### Overview - Handle case where node exits before restore bench is finished. - Fix disk space error. ### Comments [Buildkite nightly builds](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds?branch=rvl/adp-804/fix-restore-bench) The restore benchmark no longer fails from the original error. It now seems to reach the 10 hour timeout on mainnet. So the benchmark wallets need to be made smaller... in another PR. Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed:
|
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-804
Overview
Comments
Buildkite nightly builds
The restore benchmark no longer fails from the original error. It now seems to reach the 10 hour timeout on mainnet. So the benchmark wallets need to be made smaller... in another PR.