Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Instance of #2855) Flaky: HW_WALLETS_01x - Restoration from account public key preserves funds #2428

Closed
KtorZ opened this issue Jan 7, 2021 · 1 comment
Closed

(Instance of #2855) Flaky: HW_WALLETS_01x - Restoration from account public key preserves funds #2428

KtorZ opened this issue Jan 7, 2021 · 1 comment
Labels
Test failure A flaky test or nightly CI failure

Comments

@KtorZ
Copy link
Member

KtorZ commented Jan 7, 2021

Context

https://hydra.iohk.io/build/5280393

Test Case

SHELLEY_CLI_HW_WALLETS/HW_WALLETS_01x

Failure / Counter-example

  src/Test/Integration/Scenario/CLI/Shelley/HWWallets.hs:130:18: 
  3) CLI Specifications, SHELLEY_CLI_HW_WALLETS, HW_WALLETS_01x - Restoration from account public key preserves funds
       Waited longer than 90s to resolve action: "Wallet balance is as expected".
       expected: Quantity {getQuantity = 1000000}
        but got: Quantity {getQuantity = 0}
@KtorZ KtorZ added the Test failure A flaky test or nightly CI failure label Jan 7, 2021
@KtorZ KtorZ mentioned this issue Jan 7, 2021
Merged
@Anviking Anviking mentioned this issue Jan 12, 2021
Merged
6 tasks
@KtorZ KtorZ mentioned this issue Feb 15, 2021
Merged
@jonathanknowles jonathanknowles mentioned this issue Mar 5, 2021
Merged
10 tasks
This was referenced Mar 23, 2021
Merged
Merged
Merged
This was referenced Apr 20, 2021
Merged
Merged
@Anviking Anviking mentioned this issue May 7, 2021
Merged
2 tasks
@jonathanknowles jonathanknowles mentioned this issue May 21, 2021
Merged
3 tasks
This was referenced Jun 8, 2021
Merged
Closed
iohk-bors bot added a commit that referenced this issue Jun 14, 2021
@iohk-bors @Anviking @rvl
Merge #2708
4216cb5 
2708: Add more waitForTxImmutability r=Anviking a=Anviking

# Issue Number

ADP-970 / #2428 


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Replace `eventually` with `waitForTxImmutability` in exactly the locations where we've seen failures (#2428 )


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
Co-authored-by: Rodney Lorrimar <[email protected]>
@Anviking Anviking mentioned this issue Jun 14, 2021
Merged
Anviking added a commit that referenced this issue Jun 16, 2021
@Anviking
Ensure cluster setup runs without rollbacks
e1870a2 
This commit re-adds the setup specific callback from removed in 925b4d9
such that the fuacet setup is run on the BFT node, before pools are
registered and can roll back.

This should hopefully fix a #2720, #2428, and perhaps something more.
Anviking added a commit that referenced this issue Jun 16, 2021
@Anviking
Ensure cluster setup runs without rollbacks
2c30675 
This commit re-adds the setup specific callback from removed in 925b4d9
such that the fuacet setup is run on the BFT node, before pools are
registered and can roll back.

This should hopefully fix a #2720, #2428, and perhaps something more.
@Anviking Anviking mentioned this issue Jun 16, 2021
Merged
1 task
Anviking added a commit that referenced this issue Jun 16, 2021
@Anviking
Ensure cluster setup runs without rollbacks
b34687d 
This commit re-adds the setup specific callback from removed in 925b4d9
such that the fuacet setup is run on the BFT node, before pools are
registered and can roll back.

This should hopefully fix a #2720, #2428, and perhaps something more.
iohk-bors bot added a commit that referenced this issue Jun 18, 2021
@iohk-bors @Anviking @rvl
Merge #2721 #2723
7b6be98 
2721: Ensure faucet setup runs on BFT node without rollbacks r=rvl a=Anviking

# Issue Number

ADP-970, #2720, #2428


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Ensure faucet setup runs on BFT node, such that rollbacks can't mess it up


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


2723: Use LineBuffering in unit tests r=rvl a=Anviking

# Issue Number

ADP-970 / #2472 


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Try using line buffering in unit tests, like we do for integration tests


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
Co-authored-by: Rodney Lorrimar <[email protected]>
iohk-bors bot added a commit that referenced this issue Jun 18, 2021
@iohk-bors @Anviking
Merge #2721
cd40e08 
2721: Ensure faucet setup runs on BFT node without rollbacks r=rvl a=Anviking

# Issue Number

ADP-970, #2720, #2428


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Ensure faucet setup runs on BFT node, such that rollbacks can't mess it up


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
iohk-bors bot added a commit that referenced this issue Jun 18, 2021
@iohk-bors @Anviking
Merge #2721
ca9cbed 
2721: Ensure faucet setup runs on BFT node without rollbacks r=Anviking a=Anviking

# Issue Number

ADP-970, #2720, #2428


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Ensure faucet setup runs on BFT node, such that rollbacks can't mess it up


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
This was referenced Aug 25, 2021
Merged
Closed
Closed
@Anviking
Copy link
Member

Tracking as #2855

@Anviking Anviking changed the title Flaky: HW_WALLETS_01x - Restoration from account public key preserves funds (Instance of #2855) Flaky: HW_WALLETS_01x - Restoration from account public key preserves funds Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Test failure A flaky test or nightly CI failure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Anviking @KtorZ