Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky UTxOIndexSpec coverage checks #2575

Closed
Anviking opened this issue Mar 23, 2021 · 1 comment
Closed

Flaky UTxOIndexSpec coverage checks #2575

Anviking opened this issue Mar 23, 2021 · 1 comment
Labels
Test failure A flaky test or nightly CI failure

Comments

@Anviking
Copy link
Member

Context

Test Case

e.g.

    monitor $ cover 80 (Set.size (UTxOIndex.assets u) > 1)
        "index has more than one asset"

Failure / Counter-example


ci/hydra-build:required

Failures:

 test/unit/Cardano/Wallet/Primitive/Types/UTxOIndexSpec.hs:146:9:
 1) Cardano.Wallet.Primitive.Types.UTxOIndex, Indexed UTxO set properties, Index Selection, prop_selectRandom_one_withAsset
 Insufficient coverage (after 3200 tests):
 92.84% index has more than one asset
 75.46% index has the specified asset
 75.46% selected an entry

 Only 75.46% index has the specified asset, but expected 80.00%
 Only 75.46% selected an entry, but expected 80.00%

 To rerun use: --match "/Cardano.Wallet.Primitive.Types.UTxOIndex/Indexed UTxO set properties/Index Selection/prop_selectRandom_one_withAsset/"

 test/unit/Cardano/Wallet/Primitive/Types/UTxOIndexSpec.hs:148:9:
 2) Cardano.Wallet.Primitive.Types.UTxOIndex, Indexed UTxO set properties, Index Selection, prop_selectRandom_one_withAssetOnly
 Insufficient coverage (after 3200 tests):
 92.84% index has more than one asset
 75.46% index has the specified asset
 24.01% selected an entry

 Only 75.46% index has the specified asset, but expected 80.00%

 To rerun use: --match "/Cardano.Wallet.Primitive.Types.UTxOIndex/Indexed UTxO set properties/Index Selection/prop_selectRandom_one_withAssetOnly/"

 test/unit/Cardano/Wallet/Primitive/Types/UTxOIndexSpec.hs:154:9:
 3) Cardano.Wallet.Primitive.Types.UTxOIndex, Indexed UTxO set properties, Index Selection, prop_selectRandom_all_withAsset
 Insufficient coverage (after 3200 tests):
 92.84% index has more than one asset
 75.46% index has the specified asset
 75.46% selected at least one entry

 Only 75.46% index has the specified asset, but expected 80.00%
 Only 75.46% selected at least one entry, but expected 80.00%

 To rerun use: --match "/Cardano.Wallet.Primitive.Types.UTxOIndex/Indexed UTxO set properties/Index Selection/prop_selectRandom_all_withAsset/"

 test/unit/Cardano/Wallet/Primitive/Types/UTxOIndexSpec.hs:156:9:
 4) Cardano.Wallet.Primitive.Types.UTxOIndex, Indexed UTxO set properties, Index Selection, prop_selectRandom_all_withAssetOnly
 Insufficient coverage (after 3200 tests):
 92.84% index has more than one asset
 75.46% index has the specified asset
 24.01% selected at least one entry

 Only 75.46% index has the specified asset, but expected 80.00%

 To rerun use: --match "/Cardano.Wallet.Primitive.Types.UTxOIndex/Indexed UTxO set properties/Index Selection/prop_selectRandom_all_withAssetOnly/"

Randomized with seed 1756206177

Resolution

QA
@Anviking Anviking added the Test failure A flaky test or nightly CI failure label Mar 23, 2021
This was referenced Mar 23, 2021
Merged
Merged
Merged
iohk-bors bot added a commit that referenced this issue Mar 30, 2021
@iohk-bors @Anviking
Merge #2574
6b04255 
2574: Decrease coverage requirement in UTxOIndexSpec r=Anviking a=Anviking


# Issue Number

#2575

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Decrease all `coverage 80` to `coverage 70` inside UTxOIndexSpec


# Comments


<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
iohk-bors bot added a commit that referenced this issue Mar 30, 2021
@iohk-bors @Anviking
Merge #2574
7c7e57e 
2574: Decrease coverage requirement in UTxOIndexSpec r=Anviking a=Anviking


# Issue Number

#2575

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Decrease all `coverage 80` to `coverage 70` inside UTxOIndexSpec


# Comments


<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
iohk-bors bot added a commit that referenced this issue Mar 30, 2021
@iohk-bors @Anviking
Merge #2574
f76e1d8 
2574: Decrease coverage requirement in UTxOIndexSpec r=Anviking a=Anviking


# Issue Number

#2575

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Decrease all `coverage 80` to `coverage 70` inside UTxOIndexSpec


# Comments


<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
iohk-bors bot added a commit that referenced this issue Mar 30, 2021
@iohk-bors @Anviking
Merge #2574
e6336b1 
2574: Decrease coverage requirement in UTxOIndexSpec r=Anviking a=Anviking


# Issue Number

#2575

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Decrease all `coverage 80` to `coverage 70` inside UTxOIndexSpec


# Comments


<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
iohk-bors bot added a commit that referenced this issue Mar 30, 2021
@iohk-bors @Anviking
Merge #2574
eae53d4 
2574: Decrease coverage requirement in UTxOIndexSpec r=Anviking a=Anviking


# Issue Number

#2575

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Decrease all `coverage 80` to `coverage 70` inside UTxOIndexSpec


# Comments


<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
iohk-bors bot added a commit that referenced this issue Apr 1, 2021
@iohk-bors @Anviking
Merge #2574
3050491 
2574: Decrease coverage requirement in UTxOIndexSpec r=Anviking a=Anviking


# Issue Number

#2575

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Decrease all `coverage 80` to `coverage 70` inside UTxOIndexSpec


# Comments


<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
iohk-bors bot added a commit that referenced this issue Apr 1, 2021
@iohk-bors @Anviking
Merge #2574
2185692 
2574: Decrease coverage requirement in UTxOIndexSpec r=Anviking a=Anviking


# Issue Number

#2575

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Decrease all `coverage 80` to `coverage 70` inside UTxOIndexSpec


# Comments


<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
iohk-bors bot added a commit that referenced this issue Apr 1, 2021
@iohk-bors @Anviking
Merge #2574
8b41c83 
2574: Decrease coverage requirement in UTxOIndexSpec r=Anviking a=Anviking


# Issue Number

#2575

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Decrease all `coverage 80` to `coverage 70` inside UTxOIndexSpec


# Comments


<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
iohk-bors bot added a commit that referenced this issue Apr 1, 2021
@iohk-bors @Anviking
Merge #2574
eea7fba 
2574: Decrease coverage requirement in UTxOIndexSpec r=Anviking a=Anviking


# Issue Number

#2575

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Decrease all `coverage 80` to `coverage 70` inside UTxOIndexSpec


# Comments


<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
iohk-bors bot added a commit that referenced this issue Apr 2, 2021
@iohk-bors @Anviking
Merge #2574
0528219 
2574: Decrease coverage requirement in UTxOIndexSpec r=Anviking a=Anviking


# Issue Number

#2575

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Decrease all `coverage 80` to `coverage 70` inside UTxOIndexSpec


# Comments


<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
iohk-bors bot added a commit that referenced this issue Apr 2, 2021
@iohk-bors @Anviking
Merge #2574
7acc8ac 
2574: Decrease coverage requirement in UTxOIndexSpec r=Anviking a=Anviking


# Issue Number

#2575

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Decrease all `coverage 80` to `coverage 70` inside UTxOIndexSpec


# Comments


<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
@Anviking
Copy link
Member Author

Anviking commented Apr 4, 2021

Should be fixed.

@Anviking Anviking closed this as completed Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Test failure A flaky test or nightly CI failure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Anviking