Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting listen address for API server #833

Closed
2 tasks done
rvl opened this issue Oct 16, 2019 · 3 comments
Closed
2 tasks done

Allow setting listen address for API server #833

rvl opened this issue Oct 16, 2019 · 3 comments
Assignees
@rvl
Milestone
Usability & Compa...

Comments

@rvl
Copy link
Contributor

rvl commented Oct 16, 2019 •
edited
Loading

Context

Have the wallet be able to listen on interfaces other than localhost. Relevant to these situations:

  • Connecting to a wallet server on a remote host.
  • Running the wallet server within a docker container.

Decision

  • Add a command-line option --listen-address to serve and launch which accepts an IP address or hostname.
  • The special address 0.0.0.0 means listen on all interfaces. HostPreference specification

Acceptance Criteria

  • It must be possible to connect to the wallet server over the network interface specified by --listen-address
  • The default listen address must remain as localhost.
  • IPv6 may be supported

Development Plan

PR

Number Base
#838 master

QA

  • For the server, using various listen addresses are tested with unit tests in lib/core/test/unit/Cardano/Wallet/Api/ServerSpec.hs. Error cases are also tested.
  • Documentation updated in Wiki.
@rvl rvl self-assigned this Oct 16, 2019
@KtorZ KtorZ added this to the Command Line Improvements milestone Oct 16, 2019
@rvl rvl mentioned this issue Oct 16, 2019
Merged
iohk-bors bot added a commit that referenced this issue Oct 17, 2019
@iohk-bors @rvl
@KtorZ @Anviking
Merge #838 #844 #859
5e8617b 
838: Add --listen-address=127.0.0.1 option r=KtorZ a=rvl

Relates to #833 

# Overview

The host option follows the specification here: http://hackage.haskell.org/package/streaming-commons-0.2.1.0/docs/Data-Streaming-Network.html#t:HostPreference

# Comments

CLI client can still only connect to localhost.


844: Add and 'implement' "listByronTransactions" to the API r=KtorZ a=KtorZ

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->

#779

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] I have added a `GET /byron-wallets/{walletId}/transactions` to get the list of transactions for a byron wallet
- [x] The implementation is actually the same as the one for sequential wallets, so we could consider testing done here 😅 ? @piotr-iohk ?

# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
-->


859: Relocate C.W.Jormungandr.BlockHeaders to C.W.Network.BlockHeaders r=KtorZ a=Anviking

# Issue Number

#711 


# Overview

- [x] Relocate Cardano.Wallet.Jormungandr.BlockHeaders to Cardano.Wallet.Network.BlockHeaders. `Cardano.Pool.Metrics` needs them!

# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Rodney Lorrimar <[email protected]>
Co-authored-by: KtorZ <[email protected]>
Co-authored-by: Johannes Lund <[email protected]>
iohk-bors bot added a commit that referenced this issue Oct 17, 2019
@iohk-bors @rvl
Merge #838
36859f4 
838: Add --listen-address=127.0.0.1 option r=KtorZ a=rvl

Relates to #833 

# Overview

The host option follows the specification here: http://hackage.haskell.org/package/streaming-commons-0.2.1.0/docs/Data-Streaming-Network.html#t:HostPreference

# Comments

CLI client can still only connect to localhost.


Co-authored-by: Rodney Lorrimar <[email protected]>
iohk-bors bot added a commit that referenced this issue Oct 18, 2019
@iohk-bors @rvl
Merge #838
bac66d0 
838: Add --listen-address=127.0.0.1 option r=KtorZ a=rvl

Relates to #833 

# Overview

The host option follows the specification here: http://hackage.haskell.org/package/streaming-commons-0.2.1.0/docs/Data-Streaming-Network.html#t:HostPreference

# Comments

CLI client can still only connect to localhost.


Co-authored-by: Rodney Lorrimar <[email protected]>
iohk-bors bot added a commit that referenced this issue Oct 21, 2019
@iohk-bors @rvl
Merge #838
5b4ca07 
838: Add --listen-address=127.0.0.1 option r=KtorZ a=rvl

Relates to #833 

# Overview

The host option follows the specification here: http://hackage.haskell.org/package/streaming-commons-0.2.1.0/docs/Data-Streaming-Network.html#t:HostPreference

# Comments

CLI client can still only connect to localhost.


Co-authored-by: Rodney Lorrimar <[email protected]>
@rvl rvl mentioned this issue Nov 4, 2019
Closed
2 tasks
@rvl
Copy link
Contributor Author

rvl commented Nov 4, 2019

I moved the client part of this ticket to #949.

@KtorZ
Copy link
Member

KtorZ commented Nov 4, 2019

We should probably move that to JIRA as a U/S for now. Although that something I'd like to see happening, we don't have any room for this at the moment.

@piotr-iohk
Copy link
Contributor

lgtm.

Anviking added a commit that referenced this issue Jan 29, 2021
@Anviking
Remove 0.2% restore bench to prevent nightly timeouts
4b71dea 
A few recent nightlies are timing out:

- [Build #833](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/833#f00662b3-a0d0-4e59-bdaf-d097ef06f86c) -> about to timeout
    - Node sync took 2.3h
        - [2021-01-29 00:32:52.77 UTC]
        - [2021-01-29 02:52:00.75 UTC]
- [Build #832](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/832#55f4c9bb-40fa-41ee-a6a8-c028b6bdcc4b) timed out
    - Node sync took 2.4h
        - [2021-01-28 00:31:59.32 UTC]
        - [2021-01-28 02:56:13.76 UTC]
- [Build #830](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/830#31d4a3e2-eec2-4344-bad5-e8bbddffbe85) succeeded
    - Node sync took 1.32h
        - [2021-01-27 01:08:39.55 UTC]
        - [2021-01-27 03:28:23.57 UTC]

To be safe, we could make the tests shorter.

We should gain about an hour from removing 0.2% seq and rnd.

Now we have 0%, 0.1% and 0.4%.

I don't think there's a better candidate for removing:

All results:
BenchSeqResults:
  benchName: 1-wallets-to-0.1
  restoreTime: 41.27 s
  readWalletTime: 7.077 ms
  listAddressesTime: 84.37 Î?s
  listTransactionsTime: 401.7 Î?s
  estimateFeesTime: 95.49 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 10-wallets-to-0.01
  restoreTime: 38.70 s
  readWalletTime: 203.1 ms
  listAddressesTime: 219.6 ms
  listTransactionsTime: 133.9 ms
  estimateFeesTime: 452.7 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 20-wallets-to-0.01
  restoreTime: 74.61 s
  readWalletTime: 797.4 ms
  listAddressesTime: 132.9 ms
  listTransactionsTime: 151.0 ms
  estimateFeesTime: 106.3 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 40-wallets-to-0.01
  restoreTime: 165.5 s
  readWalletTime: 1.407 ms
  listAddressesTime: 519.9 Î?s
  listTransactionsTime: 580.7 Î?s
  estimateFeesTime: 94.64 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 80-wallets-to-0.01
  restoreTime: 409.6 s
  readWalletTime: 11.70 ms
  listAddressesTime: 2.015 ms
  listTransactionsTime: 2.020 ms
  estimateFeesTime: 103.4 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 100-wallets-to-0.01
  restoreTime: 563.5 s
  readWalletTime: 8.196 ms
  listAddressesTime: 2.235 ms
  listTransactionsTime: 380.9 Î?s
  estimateFeesTime: 238.3 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 0-percent-seq
  restoreTime: 490.2 s
  readWalletTime: 414.0 Î?s
  listAddressesTime: 72.47 Î?s
  listTransactionsTime: 270.5 Î?s
  estimateFeesTime: 67.40 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 0.1-percent-seq
  restoreTime: 1053 s
  readWalletTime: 23.79 ms
  listAddressesTime: 29.23 ms
  listTransactionsTime: 13.13 s
  estimateFeesTime: 291.8 ms
  walletOverview:
     number of addresses: 7744
     number of transactions: 13243
     = Total value of 28889686415572 lovelace across 916 UTxOs

BenchSeqResults:
  benchName: 0.2-percent-seq
  restoreTime: 1982 s
  readWalletTime: 88.99 ms
  listAddressesTime: 134.3 ms
  listTransactionsTime: 49.45 s
  estimateFeesTime: 941.2 ms
  walletOverview:
     number of addresses: 21521
     number of transactions: 35377
     = Total value of 44102340460783 lovelace across 1766 UTxOs

BenchSeqResults:
  benchName: 0.4-percent-seq
  restoreTime: 3701 s
  readWalletTime: 773.8 ms
  listAddressesTime: 396.3 ms
  listTransactionsTime: 163.5 s
  estimateFeesTime: 1.612 s
  walletOverview:
     number of addresses: 38287
     number of transactions: 63070
     = Total value of 84999797989729 lovelace across 3642 UTxOs

BenchRndResults:
  benchName: 0-percent-rnd
  restoreTime: 607.6 s
  readWalletTime: 477.1 Î?s
  listAddressesTime: 11.23 Î?s
  listTransactionsTime: 163.7 Î?s
  importOneAddressTime: 2.802 ms
  importManyAddressesTime: 105.1 ms
  estimateFeesTime: 30.74 ms
  walletOverview:
     number of addresses: -0
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchRndResults:
  benchName: 0.1-percent-rnd
  restoreTime: 1168 s
  readWalletTime: 12.19 ms
  listAddressesTime: 826.5 Î?s
  listTransactionsTime: 14.27 s
  importOneAddressTime: 163.6 ms
  importManyAddressesTime: 826.7 ms
  estimateFeesTime: 13.49 ms
  walletOverview:
     number of addresses: 7729
     number of transactions: 13247
     = Total value of 25389808016281 lovelace across 917 UTxOs

BenchRndResults:
  benchName: 0.2-percent-rnd
  restoreTime: 2135 s
  readWalletTime: 141.7 ms
  listAddressesTime: 2.489 ms
  listTransactionsTime: 55.26 s
  importOneAddressTime: 542.2 ms
  importManyAddressesTime: 2.966 s
  estimateFeesTime: 889.1 ms
  walletOverview:
     number of addresses: 21509
     number of transactions: 35384
     = Total value of 40607592679608 lovelace across 1770 UTxOs

BenchRndResults:
  benchName: 0.4-percent-rnd
  restoreTime: 3973 s
  readWalletTime: 187.2 ms
  listAddressesTime: 4.467 ms
  listTransactionsTime: 185.3 s
  importOneAddressTime: 1.116 s
  importManyAddressesTime: 6.352 s
  estimateFeesTime: 1.787 s
  walletOverview:
     number of addresses: 38275
     number of transactions: 63080
     = Total value of 84998315991650 lovelace across 3645 UTxOs
Anviking added a commit that referenced this issue Jan 29, 2021
@Anviking
Remove 0.2% restore bench to prevent nightly timeouts
3909f09 
A few recent nightlies are timing out:

- [Build #833](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/833#f00662b3-a0d0-4e59-bdaf-d097ef06f86c) -> about to timeout
    - Node sync took 2.3h
        - [2021-01-29 00:32:52.77 UTC]
        - [2021-01-29 02:52:00.75 UTC]
- [Build #832](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/832#55f4c9bb-40fa-41ee-a6a8-c028b6bdcc4b) timed out
    - Node sync took 2.4h
        - [2021-01-28 00:31:59.32 UTC]
        - [2021-01-28 02:56:13.76 UTC]
- [Build #830](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/830#31d4a3e2-eec2-4344-bad5-e8bbddffbe85) succeeded
    - Node sync took 2.3h
        - [2021-01-27 01:08:39.55 UTC]
        - [2021-01-27 03:28:23.57 UTC]

To be safe, we could make the tests shorter.

We should gain about an hour from removing 0.2% seq and rnd.

Now we have 0%, 0.1% and 0.4%.

I don't think there's a better candidate for removing:

All results:
BenchSeqResults:
  benchName: 1-wallets-to-0.1
  restoreTime: 41.27 s
  readWalletTime: 7.077 ms
  listAddressesTime: 84.37 Î?s
  listTransactionsTime: 401.7 Î?s
  estimateFeesTime: 95.49 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 10-wallets-to-0.01
  restoreTime: 38.70 s
  readWalletTime: 203.1 ms
  listAddressesTime: 219.6 ms
  listTransactionsTime: 133.9 ms
  estimateFeesTime: 452.7 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 20-wallets-to-0.01
  restoreTime: 74.61 s
  readWalletTime: 797.4 ms
  listAddressesTime: 132.9 ms
  listTransactionsTime: 151.0 ms
  estimateFeesTime: 106.3 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 40-wallets-to-0.01
  restoreTime: 165.5 s
  readWalletTime: 1.407 ms
  listAddressesTime: 519.9 Î?s
  listTransactionsTime: 580.7 Î?s
  estimateFeesTime: 94.64 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 80-wallets-to-0.01
  restoreTime: 409.6 s
  readWalletTime: 11.70 ms
  listAddressesTime: 2.015 ms
  listTransactionsTime: 2.020 ms
  estimateFeesTime: 103.4 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 100-wallets-to-0.01
  restoreTime: 563.5 s
  readWalletTime: 8.196 ms
  listAddressesTime: 2.235 ms
  listTransactionsTime: 380.9 Î?s
  estimateFeesTime: 238.3 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 0-percent-seq
  restoreTime: 490.2 s
  readWalletTime: 414.0 Î?s
  listAddressesTime: 72.47 Î?s
  listTransactionsTime: 270.5 Î?s
  estimateFeesTime: 67.40 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 0.1-percent-seq
  restoreTime: 1053 s
  readWalletTime: 23.79 ms
  listAddressesTime: 29.23 ms
  listTransactionsTime: 13.13 s
  estimateFeesTime: 291.8 ms
  walletOverview:
     number of addresses: 7744
     number of transactions: 13243
     = Total value of 28889686415572 lovelace across 916 UTxOs

BenchSeqResults:
  benchName: 0.2-percent-seq
  restoreTime: 1982 s
  readWalletTime: 88.99 ms
  listAddressesTime: 134.3 ms
  listTransactionsTime: 49.45 s
  estimateFeesTime: 941.2 ms
  walletOverview:
     number of addresses: 21521
     number of transactions: 35377
     = Total value of 44102340460783 lovelace across 1766 UTxOs

BenchSeqResults:
  benchName: 0.4-percent-seq
  restoreTime: 3701 s
  readWalletTime: 773.8 ms
  listAddressesTime: 396.3 ms
  listTransactionsTime: 163.5 s
  estimateFeesTime: 1.612 s
  walletOverview:
     number of addresses: 38287
     number of transactions: 63070
     = Total value of 84999797989729 lovelace across 3642 UTxOs

BenchRndResults:
  benchName: 0-percent-rnd
  restoreTime: 607.6 s
  readWalletTime: 477.1 Î?s
  listAddressesTime: 11.23 Î?s
  listTransactionsTime: 163.7 Î?s
  importOneAddressTime: 2.802 ms
  importManyAddressesTime: 105.1 ms
  estimateFeesTime: 30.74 ms
  walletOverview:
     number of addresses: -0
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchRndResults:
  benchName: 0.1-percent-rnd
  restoreTime: 1168 s
  readWalletTime: 12.19 ms
  listAddressesTime: 826.5 Î?s
  listTransactionsTime: 14.27 s
  importOneAddressTime: 163.6 ms
  importManyAddressesTime: 826.7 ms
  estimateFeesTime: 13.49 ms
  walletOverview:
     number of addresses: 7729
     number of transactions: 13247
     = Total value of 25389808016281 lovelace across 917 UTxOs

BenchRndResults:
  benchName: 0.2-percent-rnd
  restoreTime: 2135 s
  readWalletTime: 141.7 ms
  listAddressesTime: 2.489 ms
  listTransactionsTime: 55.26 s
  importOneAddressTime: 542.2 ms
  importManyAddressesTime: 2.966 s
  estimateFeesTime: 889.1 ms
  walletOverview:
     number of addresses: 21509
     number of transactions: 35384
     = Total value of 40607592679608 lovelace across 1770 UTxOs

BenchRndResults:
  benchName: 0.4-percent-rnd
  restoreTime: 3973 s
  readWalletTime: 187.2 ms
  listAddressesTime: 4.467 ms
  listTransactionsTime: 185.3 s
  importOneAddressTime: 1.116 s
  importManyAddressesTime: 6.352 s
  estimateFeesTime: 1.787 s
  walletOverview:
     number of addresses: 38275
     number of transactions: 63080
     = Total value of 84998315991650 lovelace across 3645 UTxOs
Anviking added a commit that referenced this issue Jan 29, 2021
@Anviking
Remove 0.2% restore bench to prevent nightly timeouts
7cabfad 
A few recent nightlies are timing out:

- [Build #833](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/833#f00662b3-a0d0-4e59-bdaf-d097ef06f86c) -> about to timeout
    - Node sync took 2.3h
        - [2021-01-29 00:32:52.77 UTC]
        - [2021-01-29 02:52:00.75 UTC]
- [Build #832](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/832#55f4c9bb-40fa-41ee-a6a8-c028b6bdcc4b) timed out
    - Node sync took 2.4h
        - [2021-01-28 00:31:59.32 UTC]
        - [2021-01-28 02:56:13.76 UTC]
- [Build #830](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/830#31d4a3e2-eec2-4344-bad5-e8bbddffbe85) succeeded
    - Node sync took 2.3h
        - [2021-01-27 01:08:39.55 UTC]
        - [2021-01-27 03:28:23.57 UTC]

To be safe, we could make the tests shorter.

We should gain about an hour from removing 0.2% seq and rnd.

Now we have 0%, 0.1% and 0.4%.

I don't think there's a better candidate for removing:

All results:
BenchSeqResults:
  benchName: 1-wallets-to-0.1
  restoreTime: 41.27 s
  readWalletTime: 7.077 ms
  listAddressesTime: 84.37 Î?s
  listTransactionsTime: 401.7 Î?s
  estimateFeesTime: 95.49 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 10-wallets-to-0.01
  restoreTime: 38.70 s
  readWalletTime: 203.1 ms
  listAddressesTime: 219.6 ms
  listTransactionsTime: 133.9 ms
  estimateFeesTime: 452.7 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 20-wallets-to-0.01
  restoreTime: 74.61 s
  readWalletTime: 797.4 ms
  listAddressesTime: 132.9 ms
  listTransactionsTime: 151.0 ms
  estimateFeesTime: 106.3 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 40-wallets-to-0.01
  restoreTime: 165.5 s
  readWalletTime: 1.407 ms
  listAddressesTime: 519.9 Î?s
  listTransactionsTime: 580.7 Î?s
  estimateFeesTime: 94.64 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 80-wallets-to-0.01
  restoreTime: 409.6 s
  readWalletTime: 11.70 ms
  listAddressesTime: 2.015 ms
  listTransactionsTime: 2.020 ms
  estimateFeesTime: 103.4 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 100-wallets-to-0.01
  restoreTime: 563.5 s
  readWalletTime: 8.196 ms
  listAddressesTime: 2.235 ms
  listTransactionsTime: 380.9 Î?s
  estimateFeesTime: 238.3 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 0-percent-seq
  restoreTime: 490.2 s
  readWalletTime: 414.0 Î?s
  listAddressesTime: 72.47 Î?s
  listTransactionsTime: 270.5 Î?s
  estimateFeesTime: 67.40 ms
  walletOverview:
     number of addresses: 20
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchSeqResults:
  benchName: 0.1-percent-seq
  restoreTime: 1053 s
  readWalletTime: 23.79 ms
  listAddressesTime: 29.23 ms
  listTransactionsTime: 13.13 s
  estimateFeesTime: 291.8 ms
  walletOverview:
     number of addresses: 7744
     number of transactions: 13243
     = Total value of 28889686415572 lovelace across 916 UTxOs

BenchSeqResults:
  benchName: 0.2-percent-seq
  restoreTime: 1982 s
  readWalletTime: 88.99 ms
  listAddressesTime: 134.3 ms
  listTransactionsTime: 49.45 s
  estimateFeesTime: 941.2 ms
  walletOverview:
     number of addresses: 21521
     number of transactions: 35377
     = Total value of 44102340460783 lovelace across 1766 UTxOs

BenchSeqResults:
  benchName: 0.4-percent-seq
  restoreTime: 3701 s
  readWalletTime: 773.8 ms
  listAddressesTime: 396.3 ms
  listTransactionsTime: 163.5 s
  estimateFeesTime: 1.612 s
  walletOverview:
     number of addresses: 38287
     number of transactions: 63070
     = Total value of 84999797989729 lovelace across 3642 UTxOs

BenchRndResults:
  benchName: 0-percent-rnd
  restoreTime: 607.6 s
  readWalletTime: 477.1 Î?s
  listAddressesTime: 11.23 Î?s
  listTransactionsTime: 163.7 Î?s
  importOneAddressTime: 2.802 ms
  importManyAddressesTime: 105.1 ms
  estimateFeesTime: 30.74 ms
  walletOverview:
     number of addresses: -0
     number of transactions: -0
     = Total value of -0 lovelace across 0 UTxOs

BenchRndResults:
  benchName: 0.1-percent-rnd
  restoreTime: 1168 s
  readWalletTime: 12.19 ms
  listAddressesTime: 826.5 Î?s
  listTransactionsTime: 14.27 s
  importOneAddressTime: 163.6 ms
  importManyAddressesTime: 826.7 ms
  estimateFeesTime: 13.49 ms
  walletOverview:
     number of addresses: 7729
     number of transactions: 13247
     = Total value of 25389808016281 lovelace across 917 UTxOs

BenchRndResults:
  benchName: 0.2-percent-rnd
  restoreTime: 2135 s
  readWalletTime: 141.7 ms
  listAddressesTime: 2.489 ms
  listTransactionsTime: 55.26 s
  importOneAddressTime: 542.2 ms
  importManyAddressesTime: 2.966 s
  estimateFeesTime: 889.1 ms
  walletOverview:
     number of addresses: 21509
     number of transactions: 35384
     = Total value of 40607592679608 lovelace across 1770 UTxOs

BenchRndResults:
  benchName: 0.4-percent-rnd
  restoreTime: 3973 s
  readWalletTime: 187.2 ms
  listAddressesTime: 4.467 ms
  listTransactionsTime: 185.3 s
  importOneAddressTime: 1.116 s
  importManyAddressesTime: 6.352 s
  estimateFeesTime: 1.787 s
  walletOverview:
     number of addresses: 38275
     number of transactions: 63080
     = Total value of 84998315991650 lovelace across 3645 UTxOs
iohk-bors bot added a commit that referenced this issue Jan 29, 2021
@iohk-bors @Anviking
Merge #2477 #2478
d96b11d 
2477: Remove 0.2% restore bench to prevent nightly timeouts r=Anviking a=Anviking

# Context

The original problem in ADP-639 just disappeared... But now, a few recent nightlies are timing out:

- [Build #833](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/833#f00662b3-a0d0-4e59-bdaf-d097ef06f86c) -> about to timeout
    - Node sync took 2.3h
        - [2021-01-29 00:32:52.77 UTC]
        - [2021-01-29 02:52:00.75 UTC]
- [Build #832](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/832#55f4c9bb-40fa-41ee-a6a8-c028b6bdcc4b) timed out
    - Node sync took 2.4h
        - [2021-01-28 00:31:59.32 UTC]
        - [2021-01-28 02:56:13.76 UTC]
- [Build #830](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/830#31d4a3e2-eec2-4344-bad5-e8bbddffbe85) succeeded
    - Node sync took 2.3h
        - [2021-01-27 01:08:39.55 UTC]
        - [2021-01-27 03:28:23.57 UTC]


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Removed 0.2% seq and 0.2% rnd benchmarks to gain about an hour

# Comments

- Now we have 0%, 0.1% and 0.4%. Don't think 0.2% provides anything that 0.4% doesn't.
- Haven't looked close into what causes the variability, but I think simply removing 0.2% is a fine thing still?

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


2478: update readme and migration-tests.nix with v2021-01-28 r=KtorZ a=piotr-iohk

# Issue Number

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ] updated readme and migration-tests.nix with v2021-01-28


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
Co-authored-by: Piotr Stachyra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rvl rvl

Labels
None yet
Projects
None yet
Milestone
Usability & Compatibility
Development

No branches or pull requests
3 participants
@rvl @KtorZ @piotr-iohk