Skip to content

Commit

Permalink
Merge #2477 #2478
Browse files Browse the repository at this point in the history
2477: Remove 0.2% restore bench to prevent nightly timeouts r=Anviking a=Anviking

# Context

The original problem in ADP-639 just disappeared... But now, a few recent nightlies are timing out:

- [Build #833](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/833#f00662b3-a0d0-4e59-bdaf-d097ef06f86c) -> about to timeout
    - Node sync took 2.3h
        - [2021-01-29 00:32:52.77 UTC]
        - [2021-01-29 02:52:00.75 UTC]
- [Build #832](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/832#55f4c9bb-40fa-41ee-a6a8-c028b6bdcc4b) timed out
    - Node sync took 2.4h
        - [2021-01-28 00:31:59.32 UTC]
        - [2021-01-28 02:56:13.76 UTC]
- [Build #830](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/830#31d4a3e2-eec2-4344-bad5-e8bbddffbe85) succeeded
    - Node sync took 2.3h
        - [2021-01-27 01:08:39.55 UTC]
        - [2021-01-27 03:28:23.57 UTC]


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Removed 0.2% seq and 0.2% rnd benchmarks to gain about an hour

# Comments

- Now we have 0%, 0.1% and 0.4%. Don't think 0.2% provides anything that 0.4% doesn't.
- Haven't looked close into what causes the variability, but I think simply removing 0.2% is a fine thing still?

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


2478: update readme and migration-tests.nix with v2021-01-28 r=KtorZ a=piotr-iohk

# Issue Number

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [ ] updated readme and migration-tests.nix with v2021-01-28


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
Co-authored-by: Piotr Stachyra <[email protected]>
  • Loading branch information
3 people authored Jan 29, 2021
3 parents 185e27e + 7cabfad + ebe1fa7 commit d96b11d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ See **Installation Instructions** for each available [release](https://github.co
> | cardano-wallet | cardano-node (compatible versions) | SMASH (compatible versions)
> | --- | --- | ---
> | `master` branch | [1.25.1](https://github.com/input-output-hk/cardano-node/releases/tag/1.25.1) | [1.3.0](https://github.com/input-output-hk/smash/releases/tag/1.3.0)
> | [v2021-01-28](https://github.com/input-output-hk/cardano-wallet/releases/tag/v2021-01-28) | [1.25.1](https://github.com/input-output-hk/cardano-node/releases/tag/1.25.1) | [1.3.0](https://github.com/input-output-hk/smash/releases/tag/1.3.0)
> | [v2021-01-12](https://github.com/input-output-hk/cardano-wallet/releases/tag/v2021-01-12) | [1.24.2](https://github.com/input-output-hk/cardano-node/releases/tag/1.24.2) | [1.3.0](https://github.com/input-output-hk/smash/releases/tag/1.3.0)
> | [v2020-12-21](https://github.com/input-output-hk/cardano-wallet/releases/tag/v2020-12-21) | [1.24.2](https://github.com/input-output-hk/cardano-node/releases/tag/1.24.2) | [1.2.0](https://github.com/input-output-hk/smash/releases/tag/1.2.0)
> | [v2020-12-08](https://github.com/input-output-hk/cardano-wallet/releases/tag/v2020-12-08) | [1.24.2](https://github.com/input-output-hk/cardano-node/releases/tag/1.24.2) | [1.2.0](https://github.com/input-output-hk/smash/releases/tag/1.2.0)
## How to build from sources

Expand Down
2 changes: 0 additions & 2 deletions lib/shelley/bench/Restore.hs
Original file line number Diff line number Diff line change
Expand Up @@ -308,12 +308,10 @@ cardanoRestoreBench tr c socketFile = do

, benchRestoreSeqWithOwnership (Proxy @0)
, benchRestoreSeqWithOwnership (Proxy @1)
, benchRestoreSeqWithOwnership (Proxy @2)
, benchRestoreSeqWithOwnership (Proxy @4)

, benchRestoreRndWithOwnership (Proxy @0)
, benchRestoreRndWithOwnership (Proxy @1)
, benchRestoreRndWithOwnership (Proxy @2)
, benchRestoreRndWithOwnership (Proxy @4)
]
where
Expand Down
4 changes: 2 additions & 2 deletions nix/migration-tests.nix
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ let
# One can get sha256 for release via nix-prefetch-url, e.g. for v2020.11.3:
# nix-prefetch-url --unpack https://github.com/input-output-hk/cardano-wallet/archive/v2020-11-03.zip
releases = [
{ rev = "v2020-09-11";
sha256 = "0755ggsgnlg6p0pnnrcjnbwbfg61faiyjnzng3vsva2nvg3sxn20"; }
{ rev = "v2020-09-22";
sha256 = "1nfzfdv03nz2bhin2jflxsmh597vkjifb76jsdg0384x89gi0a10"; }
{ rev = "v2020-09-30";
Expand All @@ -58,6 +56,8 @@ let
sha256 = "1i2x6ckbw7a1r4wmlf2z84ici124iqqs6vl0i0qlix85gq1j33gi"; }
{ rev = "v2021-01-12";
sha256 = "1ypkyn2s12nxwrk1ims8vrhhyy1xl3v5y35yxrwvqp8y8m2sac2x"; }
{ rev = "v2021-01-28";
sha256 = "0xszv7k531p7jsragvhy5248ihni3alajzd5csjalpv28vd4j0sk"; }
];

# Download the sources for a release.
Expand Down

0 comments on commit d96b11d

Please sign in to comment.