Add and 'implement' "listByronTransactions" to the API #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
force-pushed
the
KtorZ/byron-list-transactions
branch
from
a8d4807 to
3249615
Compare
jonathanknowles
previously requested changes
Oct 16, 2019
KtorZ
force-pushed
the
KtorZ/review-swagger-hierarchy
branch
from
06cd335 to
d9bcf54
Compare
I don't think so! :) |
rvl
approved these changes
Oct 17, 2019
specifications/api/swagger.yaml
Outdated
| <p align="right">status: <strong>stable</strong></p> | ||
| responses: *responsesGetNetworkInformation | ||
|
|
||
| /proxy/transactions: |
There was a problem hiding this comment.
I'm feeling lukewarm about the name "proxy" (conveys mechanism), but this is probably splitting hairs.
KtorZ
force-pushed
the
KtorZ/byron-list-transactions
branch
from
3249615 to
2e7ab35
Compare
KtorZ
force-pushed
the
KtorZ/byron-list-transactions
branch
2 times, most recently
from
0b01dfb to
6dd6729
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 17, 2019
838: Add --listen-address=127.0.0.1 option r=KtorZ a=rvl Relates to #833 # Overview The host option follows the specification here: http://hackage.haskell.org/package/streaming-commons-0.2.1.0/docs/Data-Streaming-Network.html#t:HostPreference # Comments CLI client can still only connect to localhost. 844: Add and 'implement' "listByronTransactions" to the API r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #779 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have added a `GET /byron-wallets/{walletId}/transactions` to get the list of transactions for a byron wallet - [x] The implementation is actually the same as the one for sequential wallets, so we could consider testing done here 😅 ? @piotr-iohk ? # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> 859: Relocate C.W.Jormungandr.BlockHeaders to C.W.Network.BlockHeaders r=KtorZ a=Anviking # Issue Number #711 # Overview - [x] Relocate Cardano.Wallet.Jormungandr.BlockHeaders to Cardano.Wallet.Network.BlockHeaders. `Cardano.Pool.Metrics` needs them! # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: KtorZ <[email protected]> Co-authored-by: Johannes Lund <[email protected]>
Build failed (retrying...) |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 17, 2019
844: Add and 'implement' "listByronTransactions" to the API r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #779 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have added a `GET /byron-wallets/{walletId}/transactions` to get the list of transactions for a byron wallet - [x] The implementation is actually the same as the one for sequential wallets, so we could consider testing done here 😅 ? @piotr-iohk ? # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> 859: Relocate C.W.Jormungandr.BlockHeaders to C.W.Network.BlockHeaders r=KtorZ a=Anviking # Issue Number #711 # Overview - [x] Relocate Cardano.Wallet.Jormungandr.BlockHeaders to Cardano.Wallet.Network.BlockHeaders. `Cardano.Pool.Metrics` needs them! # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <[email protected]> Co-authored-by: Johannes Lund <[email protected]>
KtorZ
force-pushed
the
KtorZ/byron-list-transactions
branch
from
6dd6729 to
89afe1a
Compare
Canceled |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 17, 2019
844: Add and 'implement' "listByronTransactions" to the API r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #779 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have added a `GET /byron-wallets/{walletId}/transactions` to get the list of transactions for a byron wallet - [x] The implementation is actually the same as the one for sequential wallets, so we could consider testing done here 😅 ? @piotr-iohk ? # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> 859: Relocate C.W.Jormungandr.BlockHeaders to C.W.Network.BlockHeaders r=KtorZ a=Anviking # Issue Number #711 # Overview - [x] Relocate Cardano.Wallet.Jormungandr.BlockHeaders to Cardano.Wallet.Network.BlockHeaders. `Cardano.Pool.Metrics` needs them! # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <[email protected]> Co-authored-by: Johannes Lund <[email protected]>
Build failed (retrying...) |
|
bors r+ |
|
Already running a review |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 17, 2019
844: Add and 'implement' "listByronTransactions" to the API r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #779 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have added a `GET /byron-wallets/{walletId}/transactions` to get the list of transactions for a byron wallet - [x] The implementation is actually the same as the one for sequential wallets, so we could consider testing done here 😅 ? @piotr-iohk ? # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#779
Overview
GET /byron-wallets/{walletId}/transactionsto get the list of transactions for a byron walletComments