Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CreateFullPage): beadcrumbs style issue #5599

Merged
merged 4 commits into from
Jul 17, 2024
Merged

fix(CreateFullPage): beadcrumbs style issue #5599

merged 4 commits into from
Jul 17, 2024

Conversation

anamikaanu96
Copy link
Contributor

Closes #5452

Fixed style issue of breadcrumb in header of CreateFullPage

What did you change? packages/ibm-products-styles/src/components/CreateFullPage/_create-full-page.scss

How did you test and verify your work? storybook

@anamikaanu96 anamikaanu96 requested a review from a team as a code owner June 26, 2024 08:20
@anamikaanu96 anamikaanu96 requested review from kennylam and IgnacioBecerra and removed request for a team June 26, 2024 08:20
@anamikaanu96 anamikaanu96 enabled auto-merge June 26, 2024 08:21
@netlify Netlify
Copy link

netlify bot commented Jun 26, 2024 •
edited
Loading

✅ Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 4acd629
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/668b93a6fb1a34000850da6d
😎 Deploy Preview https://deploy-preview-5599--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@devadula-nandan devadula-nandan self-requested a review July 1, 2024 04:38
devadula-nandan
devadula-nandan approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@devadula-nandan devadula-nandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amal-k-joy
Copy link
Contributor

Hey @matthewgallo,
Looks like we are using carbon component as it is. In carbon story book, this issue is not observed as the default button styles are overridden by styles from class cds--overflow-menu. But in CreateFullPage, this styles from this same class has got low priority. Can you share your thoughts on this behaviour?

@amal-k-joy amal-k-joy requested a review from matthewgallo July 10, 2024 13:13
@matthewgallo
Copy link
Member

matthewgallo commented Jul 10, 2024 •
edited
Loading

These changes should actually be applied to the SimpleHeader component. It is a simplified version of the PageHeader and that's where the style issues are coming from here. It has a corresponding style file (_simple-header.scss) where these fixes can be applied.

matthewgallo
matthewgallo requested changes Jul 10, 2024
View reviewed changes
Copy link
Member

@matthewgallo matthewgallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment around making these changes within _simple-header.scss.

@anamikaanu96 anamikaanu96 added this pull request to the merge queue Jul 17, 2024
Merged via the queue into carbon-design-system:main with commit 3a9e647 Jul 17, 2024
19 checks passed
@anamikaanu96 anamikaanu96 deleted the createFullPage branch July 17, 2024 15:15
annawen1 added a commit to annawen1/ibm-products that referenced this pull request Jul 17, 2024
@annawen1
Revert "fix(CreateFullPage): beadcrumbs style issue (carbon-design-sy…
59f5894 
…stem#5599)"

This reverts commit 3a9e647.
@annawen1 annawen1 mentioned this pull request Jul 17, 2024
Merged
amal-k-joy pushed a commit to amal-k-joy/ibm-products that referenced this pull request Jul 18, 2024
@annawen1
chore(revert): revert previously merged PRs (carbon-design-system#5689)
8ac63a4 
* Revert "feat(conditionBuilder): unit test cases for keyboard navigation (carbon-design-system#5688)"

This reverts commit 7f4f39a.

* Revert "fix(CreateFullPage): beadcrumbs style issue (carbon-design-system#5599)"

This reverts commit 3a9e647.
@amal-k-joy
Copy link
Contributor

amal-k-joy commented Jul 29, 2024 •
edited
Loading

See comment around making these changes within _simple-header.scss.

@anamikaanu96 ,
I could see lot of carbon styles was added redundantly to the component due to the below style import in the _storybook-styles.scss file of createFullPage. This changed the priority of the styles which caused this issue. You can see styles for .cds--btn--primary is added twice.
@use '@carbon/styles/scss/components/ui-shell' as *;

I think we can remove this line or add the particular style fix to the _storybook-styles.scss file as this issue should be specific to storybook.
@matthewgallo , Can you share your thoughts here. Shall we remove this style import.?

@matthewgallo
Copy link
Member

I agree, lets just remove the ui-shell style import from _storybook-styles.scss for CreateFullPage. It's causing specificity issues and is already imported when we import the base Carbon styles from packages/core/.storybook/carbon.scss.

@anamikaanu96 anamikaanu96 mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewgallo matthewgallo matthewgallo requested changes

@devadula-nandan devadula-nandan devadula-nandan approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-products-reviewers

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-products-reviewers

Assignees
No one assigned
Labels
status: one more review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[createFullPage]: breadcrumbs in header
4 participants
@anamikaanu96 @amal-k-joy @matthewgallo @devadula-nandan