-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CreateFullPage): breadcrumb style issue #5761
Merged
anamikaanu96
merged 3 commits into
carbon-design-system:main
from
anamikaanu96:createFullPageBreadcrumb
Aug 1, 2024
Merged
fix(CreateFullPage): breadcrumb style issue #5761
anamikaanu96
merged 3 commits into
carbon-design-system:main
from
anamikaanu96:createFullPageBreadcrumb
Aug 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anamikaanu96
requested review from
kennylam and
ariellalgilmore
and removed request for
a team
July 30, 2024 08:01
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amal-k-joy
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
matthewgallo
approved these changes
Jul 31, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 31, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 31, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 1, 2024
Merged
via the queue into
carbon-design-system:main
with commit Aug 1, 2024
f6e154f
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5452
Fixed style issue of breadcrumb in header of CreateFullPage
What did you change? removed the
'@carbon/styles/scss/components/ui-shell'
import frompackages/ibm-products/src/components/CreateFullPage/_storybook-styles.scss
as per the discussion on 5599How did you test and verify your work? storybook