Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CreateFullPage): breadcrumb style issue #5761

Merged

Conversation

anamikaanu96
Copy link
Contributor

Closes #5452

Fixed style issue of breadcrumb in header of CreateFullPage

What did you change? removed the '@carbon/styles/scss/components/ui-shell' import from packages/ibm-products/src/components/CreateFullPage/_storybook-styles.scss as per the discussion on 5599

How did you test and verify your work? storybook

@anamikaanu96 anamikaanu96 requested a review from a team as a code owner July 30, 2024 08:01
@anamikaanu96 anamikaanu96 requested review from kennylam and ariellalgilmore and removed request for a team July 30, 2024 08:01
Copy link

netlify bot commented Jul 30, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 53f058c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66ab3529bad0260008381f82
😎 Deploy Preview https://deploy-preview-5761--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@matthewgallo matthewgallo added this pull request to the merge queue Jul 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 31, 2024
@matthewgallo matthewgallo added this pull request to the merge queue Jul 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 31, 2024
@amal-k-joy amal-k-joy added this pull request to the merge queue Aug 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2024
@amal-k-joy amal-k-joy added this pull request to the merge queue Aug 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2024
@anamikaanu96 anamikaanu96 added this pull request to the merge queue Aug 1, 2024
Merged via the queue into carbon-design-system:main with commit f6e154f Aug 1, 2024
19 checks passed
@anamikaanu96 anamikaanu96 deleted the createFullPageBreadcrumb branch August 1, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[createFullPage]: breadcrumbs in header
3 participants