Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Datagrid): expandable/nested review fixes, custom hook for keeping expander focus #3861

Conversation

matthewgallo
Copy link
Member

@matthewgallo matthewgallo commented Nov 28, 2023

Contributes to #3821

Some updates after reviewing nested/expandable rows.

  • Addressed an issue where the row expanders were losing focus, thus breaking the keyboard accessibility while navigating for both nested and expandable rows.
  • Fixed invalid DOM nesting error, expandable row needed to have it's content wrapped in a td element.

What did you change?

packages/ibm-products/src/components/Datagrid/Datagrid/DatagridRow.js
packages/ibm-products/src/components/Datagrid/Extensions/ExpandableRow/ExpandableRow.stories.js
packages/ibm-products/src/components/Datagrid/Extensions/NestedRows/NestedRows.stories.js
packages/ibm-products/src/components/Datagrid/useExpandedRow.js
packages/ibm-products/src/components/Datagrid/useFocusRowExpander.js
packages/ibm-products/src/components/Datagrid/useNestedRowExpander.js
packages/ibm-products/src/components/Datagrid/useNestedRows.js
packages/ibm-products/src/components/Datagrid/useRowExpander.js
packages/ibm-products/src/global/js/package-settings.js

How did you test and verify your work?

Storybook

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 1393929
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/656a44b0171b6d0008d1b703
😎 Deploy Preview https://deploy-preview-3861--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewgallo matthewgallo marked this pull request as ready for review November 29, 2023 14:51
@matthewgallo matthewgallo requested a review from a team as a code owner November 29, 2023 14:51
@matthewgallo matthewgallo marked this pull request as draft November 29, 2023 15:19
@matthewgallo matthewgallo marked this pull request as ready for review November 29, 2023 17:17
@matthewgallo matthewgallo added this pull request to the merge queue Dec 1, 2023
Merged via the queue into carbon-design-system:main with commit ae33c58 Dec 1, 2023
12 checks passed
@matthewgallo matthewgallo deleted the 3821-nested-expandable-row-release-review-updates branch December 1, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants