-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datagrid Storybook warnings: invalid DOM nesting #3672
Comments
Fixed one instance of invalid DOM nesting with expandable rows, thinking we can take a similar approach with other instances. Essentially, any direct child of a |
a few got fixed with this #5716 |
We've been investigating TanStack Table, a third-party, open-source offering, which provides extensive data table capabilities surpassing what our Carbon Datagrid offers. It provides much more flexibility and customization. TanStack Table is headless which means it can easily be added alongside Datagrid component in your product or application. The benefits of more flexibility for product teams and less maintenance for Carbon makes it a win win. Lastly, it is available in multiple frameworks including React and Web Component so it provides an option to non-React product teams. For these reasons, we have decided to transition from building our own custom table component to using an example-based approach with TanStack Table. Datagrid will still exist in our library for existing teams but we are announcing the deprecation* of the Datagrid component in v2.54.0 release so teams can begin to work through the transition. Details about how to use both Datagrid and TanStack together can be found here. *Deprecation means that no new features will be added however sev 1 and sev 2 bugs will be supported. |
What package(s) are you using?
Detailed description
When running Storybook locally, I see console warnings across many stories.
This is not necessarily a comprehensive list. E.g.:
http://localhost:3000/?path=/story/ibm-products-components-datagrid-datagrid-canary--infinite-scroll
http://localhost:3000/?path=/story/ibm-products-components-datagrid-datagrid-canary--selectable-row
Yes, these all appear across multiple stories for the Datagrid
We should not see these console warnings at all.
Chrome, latest.
v2.11
Steps to reproduce the issue
@carbon/ibm-products
to your local machine.yarn
to install packages.yarn storybook
to run Storybook.The text was updated successfully, but these errors were encountered: