test(Datagrid): add test coverage for new hook #3879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
davidmenendez
previously approved these changes
Dec 1, 2023
elycheea
reviewed
Dec 4, 2023
| ); | ||
| const row = bodyRows[rowNumber]; | ||
|
|
||
| const rowExpander = row.querySelector(`button[aria-label="Expand row"]`); | ||
| fireEvent.click(rowExpander); | ||
| const rowExpander = within(row).getByLabelText('Expand row'); |
elycheea
approved these changes
Dec 4, 2023
Merged
via the queue into
carbon-design-system:main
with commit Dec 4, 2023
1a0ba55
12 checks passed
paul-balchin-ibm
pushed a commit
to paul-balchin-ibm/ibm-products
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: #3861 Should be reviewed/merged first
Contributes to #3821
Adds test coverage to new expander hooks to keep focus when applicable.
What did you change?
How did you test and verify your work?
Storybook and made sure all tests pass and meet coverage requirements