feat(spacing): change layout variables to spacing #8063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
requested review from
joshblack,
emyarod,
a team and
kingtraceyj
and removed request for
a team
tw15egan
changed the title
|
Deploy preview for carbon-elements ready! Built with commit d77391f |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit d77391f https://deploy-preview-8063--carbon-components-react.netlify.app |
|
@tw15egan looks good from a visual stand point. should we update the docs page on the website before you merge or do you think we could do that in the next few weeks. |
|
We can just hold off on merging this until we update the website so we're synced between the website and whats in code 👍🏻 |
joshblack
approved these changes
Mar 15, 2021
Closed
tw15egan
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5602
Deprecates the
layouttokens in favor of a singlespacingscale. This change will need to coincide with a website change to update the new/removed tokenshttps://www.carbondesignsystem.com/guidelines/spacing/overview#spacing-scale
https://www.carbondesignsystem.com/guidelines/spacing/overview#layout-scale
Changelog
New
$spacing-13to match the largestlayoutvariableChanged
$layoutto$spacing(seemed to only be in Data Table styles)layoutvariableslayoutfromthemepackage in v11Testing / Reviewing
$spacing-13