Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spacing): remove layout scale, update spacing scale #2181

Merged
merged 2 commits into from
Mar 25, 2021
Merged

feat(spacing): remove layout scale, update spacing scale #2181

merged 2 commits into from
Mar 25, 2021

Conversation

tw15egan
Copy link
Collaborator

Closes carbon-design-system/carbon#5602
Refs carbon-design-system/carbon#8063

This removes our layout scale from the website and adds the missing values to the spacing scale. Coincides with changes made in carbon-design-system/carbon#8063

Changelog

New

  • $spacing-10 through $spacing-13, mapping to deprecated $layout values

Changed

  • Updated svg filenames to match token names
  • Changed svg files for new $spacing tokens

Removed

  • Old content relating to $layout

@tw15egan tw15egan requested a review from a team March 15, 2021 18:00
@tw15egan tw15egan requested a review from a team as a code owner March 15, 2021 18:00
@vercel
Copy link

vercel bot commented Mar 15, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/2AYychpdE6wvMjzNFD1BApDNqunW
✅ Preview: https://carbondesignsy-git-fork-tw15egan-update-spacing-scale-ca-0097e0.vercel.app

@tw15egan tw15egan requested review from a team and kingtraceyj March 15, 2021 18:00
emyarod
emyarod approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me pending visual and content review

jillianhowarth
jillianhowarth approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@jillianhowarth jillianhowarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aagonzales
aagonzales approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ship it!

@aagonzales aagonzales removed the request for review from kingtraceyj March 25, 2021 17:19
@kodiakhq kodiakhq bot merged commit ebc9e07 into carbon-design-system:main Mar 25, 2021
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@tw15egan @aagonzales @natashadecoste
feat(spacing): remove layout scale, update spacing scale (carbon-desi…
cf9d761 
…gn-system#2181)

Co-authored-by: Anna Gonzales <[email protected]>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@tw15egan @aagonzales @natashadecoste
feat(spacing): remove layout scale, update spacing scale (carbon-desi…
f9979d5 
…gn-system#2181)

Co-authored-by: Anna Gonzales <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillianhowarth jillianhowarth jillianhowarth approved these changes

@aagonzales aagonzales aagonzales approved these changes

@emyarod emyarod emyarod approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update spacing scale and deprecate our layout scale
5 participants
@tw15egan @tay1orjones @emyarod @aagonzales @jillianhowarth