Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spacing scale and deprecate our layout scale #5602

Closed
joshblack opened this issue Mar 11, 2020 · 1 comment · Fixed by #8063 or carbon-design-system/carbon-website#2181
Closed

Update spacing scale and deprecate our layout scale #5602

joshblack opened this issue Mar 11, 2020 · 1 comment · Fixed by #8063 or carbon-design-system/carbon-website#2181
Assignees
@tw15egan
Labels
package: layout @carbon/layout proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖

Comments

@joshblack
Copy link
Contributor

When talking to @jeanservaas and @vpicone, it came up that it would be worth consolidating the values of layout into our spacing scale and deprecating the layout scale that we currently have.

This issue is to handle implementing any changes to the spacing scale that need to happen along with deprecating the layout scale.
@joshblack joshblack added role: dev 🤖 proposal: open This request has gone through triaging. We're determining whether we take this on or not. package: layout @carbon/layout proposal: accepted This request has gone through triaging and we are accepting PR's against it. and removed proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Mar 11, 2020
@alisonjoseph alisonjoseph mentioned this issue Jun 4, 2020
Closed
41 tasks
@tw15egan tw15egan added hacktoberfest See https://hacktoberfest.com/ and removed hacktoberfest See https://hacktoberfest.com/ labels Sep 29, 2020
@joshblack joshblack mentioned this issue Mar 8, 2021
Closed
87 tasks
@tw15egan tw15egan self-assigned this Mar 9, 2021
@tw15egan tw15egan removed the hacktoberfest See https://hacktoberfest.com/ label Mar 9, 2021
@tw15egan
Copy link
Collaborator

tw15egan commented Mar 9, 2021 •
edited
Loading

Just for clarification, would this entail the following?

  • Changing any instances of $layout-xx to $spacing-xx
  • Adding the larger layout values to the end of spacing
    • i.e. $layout-05 becomes $spacing-10
  • Adding a deprecation warning to components/src/globals/scss/_spacing variables

@tw15egan tw15egan mentioned this issue Mar 10, 2021
Merged
@joshblack joshblack mentioned this issue Mar 15, 2021
Closed
@tw15egan tw15egan mentioned this issue Mar 15, 2021
Merged
@mattrosno mattrosno mentioned this issue Jun 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tw15egan tw15egan

Labels
package: layout @carbon/layout proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖
Projects
None yet
Milestone
No milestone
2 participants
@joshblack @tw15egan