-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(type): use unitless line-heights #6714
feat(type): use unitless line-heights #6714
Conversation
Deploy preview for carbon-elements ready! Built with commit 45d91b2 |
Deploy preview for carbon-components-react ready! Built with commit 45d91b2 https://deploy-preview-6714--carbon-components-react.netlify.app |
3f75cbc
to
6ab8ff5
Compare
The changes look good code-wise, although from the percy snapshots it seems like there might be some unexpected line height changes? I'm not sure how the line-height value was computed but for I think the value of line-height should be computed by proportion instead of relative to the base font-size, so instead of |
@joshblack Ah yeah that would explain the differences... so would we need to compute that for all of them? i.e. |
@tw15egan yeah! Exactly. |
fcbe45c
to
d332519
Compare
@joshblack updated. After making these changes, I noticed there were still 29 diffs in Percy. Seems like Chrome rounds |
6c4a519
to
854304e
Compare
bd22b5c
to
86a470d
Compare
Closes #6711
Updates our type package to use a unitless
line-height
valueChangelog
Changed
scss
andjs
type scale filescarbon--rem()
to set theline-height
, we just set it to a unitless valueTesting / Reviewing
Ensure the values match the website documentation, with the exception of
heading-03
. An issue has been made for that here carbon-design-system/carbon-website#1604