Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(type): use unitless line-heights #6714

Merged
merged 8 commits into from
Aug 27, 2020
Merged

feat(type): use unitless line-heights #6714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9504d96
feat(type): use unitless line-heights
tw15egan Aug 24, 2020
5fe4f2f
chore(tests): update snapshots
tw15egan Aug 24, 2020
ab394b8
fix(type): recalculate line heights
tw15egan Aug 26, 2020
0f3a2b2
chore(snapshot): update snapshots
tw15egan Aug 26, 2020
854304e
fix(type): bump line-height to 1.34
tw15egan Aug 26, 2020
de4db8e
chore(percy): upgrade percy to 3.3.1
tw15egan Aug 27, 2020
86a470d
chore(story): clean up stories to use default line-heights
tw15egan Aug 27, 2020
45d91b2
chore(tests): update snapshots
tw15egan Aug 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed .yarn/offline-mirror/@percy-storybook-3.3.0.tgz
View file
Open in desktop
Binary file not shown.
Binary file added .yarn/offline-mirror/@percy-storybook-3.3.1.tgz
View file
Open in desktop
Binary file not shown.
241 changes: 119 additions & 122 deletions packages/components/docs/sass.md
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 7 additions & 7 deletions packages/components/src/globals/grid/__tests__/__snapshots__/grid-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,43 +4,43 @@ exports[`_grid.scss should generate grid code when the grid feature flag is on 1
"h1 {
font-size: 2.625rem;
font-weight: 300;
line-height: 3.125rem;
line-height: 1.199;
letter-spacing: 0; }

h2 {
font-size: 2rem;
font-weight: 400;
line-height: 2.5rem;
line-height: 1.25;
letter-spacing: 0; }

h3 {
font-size: 1.75rem;
font-weight: 400;
line-height: 2.25rem;
line-height: 1.29;
letter-spacing: 0; }

h4 {
font-size: 1.25rem;
font-weight: 400;
line-height: 1.75rem;
line-height: 1.4;
letter-spacing: 0; }

h5 {
font-size: 1rem;
font-weight: 600;
line-height: 1.375rem;
line-height: 1.375;
letter-spacing: 0; }

h6 {
font-size: 0.875rem;
font-weight: 600;
line-height: 1.125rem;
line-height: 1.29;
letter-spacing: 0.16px; }

p {
font-size: 1rem;
font-weight: 400;
line-height: 1.5rem;
line-height: 1.5;
letter-spacing: 0; }

a {
Expand Down
Loading