Skip to content

Commit

Permalink
chore(story): clean up stories to use default line-heights
Browse files Browse the repository at this point in the history
  • Loading branch information
tw15egan committed Aug 27, 2020
1 parent de4db8e commit bd22b5c
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 22 deletions.
16 changes: 7 additions & 9 deletions packages/react/src/components/Tooltip/Tooltip-story.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,13 @@ const props = {
''
),
// eslint-disable-next-line react/display-name
renderIcon: React.forwardRef((props, ref) => (
<div ref={ref}>
<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16">
<path d="M8.5 11V6.5h-2v1h1V11H6v1h4v-1zM8 3.5c-.4 0-.8.3-.8.8s.4.7.8.7.8-.3.8-.8-.4-.7-.8-.7z" />
<path d="M8 15c-3.9 0-7-3.1-7-7s3.1-7 7-7 7 3.1 7 7-3.1 7-7 7zM8 2C4.7 2 2 4.7 2 8s2.7 6 6 6 6-2.7 6-6-2.7-6-6-6z" />
<path fill="none" d="M0 0h16v16H0z" />
</svg>
</div>
)),
renderIcon: () => (
<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16">
<path d="M8.5 11V6.5h-2v1h1V11H6v1h4v-1zM8 3.5c-.4 0-.8.3-.8.8s.4.7.8.7.8-.3.8-.8-.4-.7-.8-.7z" />
<path d="M8 15c-3.9 0-7-3.1-7-7s3.1-7 7-7 7 3.1 7 7-3.1 7-7 7zM8 2C4.7 2 2 4.7 2 8s2.7 6 6 6 6-2.7 6-6-2.7-6-6-6z" />
<path fill="none" d="M0 0h16v16H0z" />
</svg>
),
}),
customIconOnly: () => ({
showIcon: true,
Expand Down
18 changes: 6 additions & 12 deletions packages/react/src/components/UIShell/UIShell-story.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,8 @@ const StoryContent = ({ useResponsiveOffset = true }) => {
<div className="bx--grid">
<div className="bx--row">
<div className={classNameFirstColumn}>
<h2 style={{ fontWeight: '800', margin: '30px 0', fontSize: '20px' }}>
Purpose and function
</h2>
<p style={{ lineHeight: '20px' }}>
<h2 style={{ margin: '0 0 30px' }}>Purpose and function</h2>
<p>
The shell is perhaps the most crucial piece of any UI built with
<a href="www.carbondesignsystem.com"> Carbon</a>. It contains the
shared navigation framework for the entire design system and ties
Expand All @@ -94,19 +92,15 @@ const StoryContent = ({ useResponsiveOffset = true }) => {
these parts of the Mac UI. For example, the app switcher portion of
the shell can be compared to the dock in MacOS.
</p>
<h2 style={{ fontWeight: '800', margin: '30px 0', fontSize: '20px' }}>
Header responsive behavior
</h2>
<p style={{ lineHeight: '20px' }}>
<h2 style={{ margin: '30px 0' }}>Header responsive behavior</h2>
<p>
As a header scales down to fit smaller screen sizes, headers with
persistent side nav menus should have the side nav collapse into
“hamburger” menu. See the example to better understand responsive
behavior of the header.
</p>
<h2 style={{ fontWeight: '800', margin: '30px 0', fontSize: '20px' }}>
Secondary navigation
</h2>
<p style={{ lineHeight: '20px' }}>
<h2 style={{ margin: '30px 0' }}>Secondary navigation</h2>
<p>
The side-nav contains secondary navigation and fits below the
header. It can be configured to be either fixed-width or flexible,
with only one level of nested items allowed. Both links and category
Expand Down
3 changes: 2 additions & 1 deletion packages/type/scss/_styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,8 @@ $productive-heading-05: (
$productive-heading-06: (
font-size: carbon--type-scale(8),
font-weight: carbon--font-weight('light'),
line-height: 1.19,
// Extra digit needed for precision in Chrome
line-height: 1.199,
letter-spacing: 0,
) !default;

Expand Down

0 comments on commit bd22b5c

Please sign in to comment.