feat(grid): update breakpoint-down with correct max width #5791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit f83bacd |
|
Deploy preview for carbon-components-react ready! Built with commit f83bacd https://deploy-preview-5791--carbon-components-react.netlify.com |
tw15egan
approved these changes
Apr 3, 2020
emyarod
approved these changes
Apr 3, 2020
kodiakhq bot
pushed a commit
to carbon-design-system/carbon-for-ibm-dotcom
that referenced
this pull request
Jan 20, 2021
### Related Ticket(s) #4920 ### Description Changes the target breakpoint in the media query to not include the breakpoint itself. This was causing the `L1` to be hidden in all conditions. See [this](carbon-design-system/carbon#5791) PR for more details. ### Changelog **Changed** - change `L1` responsive breakpoint to `799.98px` to exclude the breakpoint target (`800px`) <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
kodiakhq bot
pushed a commit
to carbon-design-system/carbon-for-ibm-dotcom
that referenced
this pull request
Jan 20, 2021
### Related Ticket(s) #4920 Duplicate of #4941 which targeted incorrect branch. ### Description Changes the target breakpoint in the media query to not include the breakpoint itself. This was causing the `L1` to be hidden in all conditions. See [this](carbon-design-system/carbon#5791) PR for more details. ### Changelog **Changed** - change `L1` responsive breakpoint to `799.98px` to exclude the breakpoint target (`800px`) <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
IgnacioBecerra
pushed a commit
to IgnacioBecerra/ibm-dotcom-library
that referenced
this pull request
Feb 22, 2021
…4941) ### Related Ticket(s) carbon-design-system#4920 ### Description Changes the target breakpoint in the media query to not include the breakpoint itself. This was causing the `L1` to be hidden in all conditions. See [this](carbon-design-system/carbon#5791) PR for more details. ### Changelog **Changed** - change `L1` responsive breakpoint to `799.98px` to exclude the breakpoint target (`800px`) <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5782
Updates the logic of
breakpoint-downto align more closely with the expectation that the range would not include the breakpoint itself. This borrows a bit of logic from bootstrap's implementation in order to satisfy the requirement that the breakpoint only applies for widths smaller than the given breakpoint.Changelog
New
Changed
carbon--breakpoint-downto not include given breakpoint in media queryRemoved