-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(masthead): update L1 responsive breakpoint #4941
fix(masthead): update L1 responsive breakpoint #4941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - Will be nice if a comment can be added there referring to Carbon core PR (fix) of this problem space. Thanks @kennylam!
Deploy preview created for package Built with commit: eb6bcfdf044de8fa44d32a18f522668d7b355897 |
Deploy preview created for package Built with commit: eb6bcfdf044de8fa44d32a18f522668d7b355897 |
Deploy preview created for package Built with commit: eb6bcfdf044de8fa44d32a18f522668d7b355897 |
Deploy preview created for package Built with commit: eb6bcfdf044de8fa44d32a18f522668d7b355897 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks Kenny!
### Related Ticket(s) #4920 Duplicate of #4941 which targeted incorrect branch. ### Description Changes the target breakpoint in the media query to not include the breakpoint itself. This was causing the `L1` to be hidden in all conditions. See [this](carbon-design-system/carbon#5791) PR for more details. ### Changelog **Changed** - change `L1` responsive breakpoint to `799.98px` to exclude the breakpoint target (`800px`) <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
### Description Document CSS fix applied to [#4941](#4941). ### Changelog **New** - add style comments documenting breakpoint fix <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
…4941) ### Related Ticket(s) carbon-design-system#4920 ### Description Changes the target breakpoint in the media query to not include the breakpoint itself. This was causing the `L1` to be hidden in all conditions. See [this](carbon-design-system/carbon#5791) PR for more details. ### Changelog **Changed** - change `L1` responsive breakpoint to `799.98px` to exclude the breakpoint target (`800px`) <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
### Description Document CSS fix applied to [carbon-design-system#4941](carbon-design-system#4941). ### Changelog **New** - add style comments documenting breakpoint fix <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Related Ticket(s)
#4920
Description
Changes the target breakpoint in the media query to not include the breakpoint itself. This was causing the
L1
to be hidden in all conditions. See this PR for more details.Changelog
Changed
L1
responsive breakpoint to799.98px
to exclude the breakpoint target (800px
)