We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
carbon-components
carbon-components-react
Looking at https://github.com/carbon-design-system/carbon/blob/master/packages/layout/scss/_breakpoint.scss, using a mixin like
@carbon--breakpoint-down(lg)
will generate CSS like below (or the equivalent in rem):
rem
@media (max-width: 1056px) { ... }
IIUC, that means width <= 1056px, whereas what we want is width < 1056px. I.E. a query that doesn't match when width === 1056px.
width <= 1056px
width < 1056px
width === 1056px
Maybe it should be generating @media not (min-width: 1056px) instead?
@media not (min-width: 1056px)
Or by using media queries level 4 (not sure if that works for all browsers that carbon supports), generate:
@media (width < 1056) { ... }
The text was updated successfully, but these errors were encountered:
carbon--breakpoint-between
joshblack
Successfully merging a pull request may close this issue.
What package(s) are you using?
carbon-components
carbon-components-react
Detailed description
Looking at https://github.com/carbon-design-system/carbon/blob/master/packages/layout/scss/_breakpoint.scss, using a mixin like
will generate CSS like below (or the equivalent in
rem
):IIUC, that means
width <= 1056px
, whereas what we want iswidth < 1056px
. I.E. a query that doesn't match whenwidth === 1056px
.Maybe it should be generating
@media not (min-width: 1056px)
instead?Or by using media queries level 4 (not sure if that works for all browsers that carbon supports), generate:
The text was updated successfully, but these errors were encountered: