feat(type): add Plex Sans Condensed #5680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 463410b |
|
Deploy preview for carbon-components-react ready! Built with commit 463410b https://deploy-preview-5680--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 3f5cc98 |
|
Deploy preview for carbon-components-react ready! Built with commit 3f5cc98 https://deploy-preview-5680--carbon-components-react.netlify.com |
joshblack
reviewed
Mar 24, 2020
|
@joshblack seems like it's been in there, we just weren't declaring the Or did you mean somewhere else? Not too familiar with the |
|
Oh perfect! Sounds great |
joshblack
approved these changes
Mar 24, 2020
tw15egan
added
component: accordion
status: one more review 👀
status: ready for review 👀
and removed
component: accordion
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5615
Adds in Plex Sans Condensed font-face declarations.
Changelog
New
Changed
Testing / Reviewing
Go to
type/examplesfolder, build, then run the example. Ensure that Condensed styles are being shown in all browsers.