Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scss] remove plex unpkg @font-face declarations #1007

Closed
tay1orjones opened this issue Mar 13, 2020 · 2 comments · Fixed by #1368
Closed

[scss] remove plex unpkg @font-face declarations #1007

tay1orjones opened this issue Mar 13, 2020 · 2 comments · Fixed by #1368
Assignees
@JesseSprinkle
Labels
good first issue 👋 Good for newcomers has internal tracking issue issues that have a link to an issue on the internal IBM tracking/reporting repository migrated from internal repo items confirmed to be moved from the internal repo to this repo released type: enhancement 💡 New feature or request
Milestone
Sprint 52

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Mar 13, 2020 •
edited
Loading

Internal Watson-IoT/pal-tracking#388

In #1003 it was identified that plex condensed wasn't being loaded because it's not currently included in @carbon/type.

In #998 additional @font-face declarations were put in for these missing files. A url pointing to unpkg was used to avoid an increase in bundle size.

This should eventually be fixed upstream either by Carbon adding the required declarations to @carbon/type or @carbon/charts could expose/include this typeface through their package. Here is a link to internal slack discussion

Either way, once this is fixed upstream we should remove the @font-face declarations that were added in #998

Update - open PR on Carbon: carbon-design-system/carbon#5680
This was referenced Mar 13, 2020
Closed
Merged
Closed
@tay1orjones
Copy link
Member Author

tay1orjones commented Apr 27, 2020 •
edited
Loading

Should be available in Carbon v10.11.x. Once we update we can remove our declarations

@tay1orjones tay1orjones added the has internal tracking issue issues that have a link to an issue on the internal IBM tracking/reporting repository label Apr 27, 2020
@tay1orjones tay1orjones removed on hold type: enhancement 💡 New feature or request labels Jun 2, 2020
@tay1orjones tay1orjones added this to the Sprint 49 milestone Jun 2, 2020
@tay1orjones tay1orjones added migrated from internal repo items confirmed to be moved from the internal repo to this repo dependent on: carbon Items present upstream in Carbon Design System and removed dependent on: carbon Items present upstream in Carbon Design System labels Jun 2, 2020
@tay1orjones tay1orjones self-assigned this Jun 2, 2020
@davidicus davidicus modified the milestones: Sprint 49, Sprint 50 Jun 8, 2020
@davidicus davidicus added the good first issue 👋 Good for newcomers label Jun 15, 2020
@davidicus davidicus modified the milestones: Sprint 50, Sprint 51 Jun 23, 2020
@davidicus davidicus modified the milestones: Sprint 51, Sprint 52 Jul 6, 2020
@JesseSprinkle JesseSprinkle self-assigned this Jul 6, 2020
@JesseSprinkle JesseSprinkle mentioned this issue Jul 6, 2020
Merged
@tay1orjones
Copy link
Member Author

🎉 This issue has been resolved in version 2.100.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@davidicus davidicus added the type: enhancement 💡 New feature or request label Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JesseSprinkle JesseSprinkle

Labels
good first issue 👋 Good for newcomers has internal tracking issue issues that have a link to an issue on the internal IBM tracking/reporting repository migrated from internal repo items confirmed to be moved from the internal repo to this repo released type: enhancement 💡 New feature or request
Projects
None yet
Milestone
Sprint 52
3 participants
@davidicus @tay1orjones @JesseSprinkle