feat(tablecard): do not require the threshold column be shown in a table #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottdickerson
requested review from
blechner,
bryancboyd,
cgirani,
davidicus,
filipecorrea,
jessieyan,
leetosc,
sstone2423,
stuckless,
tay1orjones and
tomklapiscak
as code owners
|
Deploy preview for carbon-addons-iot-react ready! Built with commit b930a72 https://deploy-preview-998--carbon-addons-iot-react.netlify.com |
|
Deploy preview for carbon-addons-iot-react ready! Built with commit 5d9a351 https://deploy-preview-998--carbon-addons-iot-react.netlify.com |
|
Deploy preview for carbon-addons-iot-react ready! Built with commit 6633620 https://deploy-preview-998--carbon-addons-iot-react.netlify.com |
tay1orjones
requested changes
Mar 12, 2020
tay1orjones
requested changes
Mar 13, 2020
scottdickerson
force-pushed
the
fix-dashboard-card
branch
from
bd63d69 to
6633620
Compare
tay1orjones
approved these changes
Mar 13, 2020
|
I've opened #1007 to follow on from this to remove our fix once it's fixed upstream in either |
|
🎉 This PR is included in version 2.57.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Summary
Change List (commits, features, bugs, etc)
Acceptance Test (how to verify the PR)