Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Carbon Type Package]: Add IBM Plex Condensed #5615

Closed
mjabbink opened this issue Mar 12, 2020 · 7 comments · Fixed by #5680
Closed

[Carbon Type Package]: Add IBM Plex Condensed #5615

mjabbink opened this issue Mar 12, 2020 · 7 comments · Fixed by #5680
Assignees

Comments

@mjabbink
Copy link

Carbon Charts uses the condensed in X and Y-axis and axis labels
https://carbon-design-system.github.io/carbon-charts/

Teams like IoT are using Carbon Charts and getting Helvetica in place of Plex Condensed in all their Bar Chart versions
https://carbon-addons-iot-react.com/?path=/story/watson-iot-experimental-barchartcard--simple-bar

sample:
Screen Shot 2020-03-12 at 6 03 31 PM

@tw15egan
Copy link
Collaborator

tw15egan commented Mar 13, 2020

Very odd... I get the correct fonts in Chrome:

Screen Shot 2020-03-13 at 9 44 28 AM

But I get Helv in Safari / on mobile

Screen Shot 2020-03-13 at 9 46 07 AM

Possibly because I have the fonts loaded on my laptop.

@joshblack seems like we need to add IBM Plex Sans Condensed to the font-face declarations?

@joshblack
Copy link
Contributor

@tw15egan ah do we use condensed for charts??

@tw15egan
Copy link
Collaborator

Yeah seems like it so we need a way to turn on the condensed styles. Doesn't look like we ship that out as it stands? Do we just need to mimic the other font-face files in type/scss/font-face, and add one in for _sansCondensed?

@vpicone
Copy link
Contributor

vpicone commented Mar 13, 2020

@tw15egan that’s my impression. We just don’t provide the google fonts @font-face declarations for condensed Plex like we do for serif, sans, and mono.

Considering we supply the sources for Serif despite not using it in Carbon/product, it seems like it we should be including it.

@tw15egan
Copy link
Collaborator

tw15egan commented Mar 13, 2020

Do you know how / where we get the url for the fonts?

e.g.

url(https://fonts.gstatic.com/s/ibmplexsans/v6/zYX7KVElMYYaJe8bpLHnCwDKhdTmvIRcdvfo.woff)

@vpicone
Copy link
Contributor

vpicone commented Mar 14, 2020

@tw15egan we just get them off google fonts. Typically when someone uses google fonts, the link they give you fetches a style sheet With the latest font face definitions. We just do that fetch a head of time and commit it. The negative side effect is that our version of Plex can get out dated. Here’s the link for they give for condensed.

https://fonts.googleapis.com/css2?family=IBM+Plex+Sans+Condensed

@theiliad
Copy link
Member

@tw15egan On a machine where I have Plex installed I'd get Plex on the IoT pages because the browser will locate the font locally. But if you don't have it installed you'll get the fallback fonts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants