-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Carbon Type Package]: Add IBM Plex Condensed #5615
Comments
Very odd... I get the correct fonts in Chrome: But I get Helv in Safari / on mobile Possibly because I have the fonts loaded on my laptop. @joshblack seems like we need to add |
@tw15egan ah do we use condensed for charts?? |
Yeah seems like it so we need a way to turn on the condensed styles. Doesn't look like we ship that out as it stands? Do we just need to mimic the other |
@tw15egan that’s my impression. We just don’t provide the google fonts Considering we supply the sources for Serif despite not using it in Carbon/product, it seems like it we should be including it. |
Do you know how / where we get the url for the fonts? e.g.
|
@tw15egan we just get them off google fonts. Typically when someone uses google fonts, the link they give you fetches a style sheet With the latest font face definitions. We just do that fetch a head of time and commit it. The negative side effect is that our version of Plex can get out dated. Here’s the link for they give for condensed. https://fonts.googleapis.com/css2?family=IBM+Plex+Sans+Condensed |
@tw15egan On a machine where I have Plex installed I'd get Plex on the IoT pages because the browser will locate the font locally. But if you don't have it installed you'll get the fallback fonts |
Carbon Charts uses the condensed in X and Y-axis and axis labels
https://carbon-design-system.github.io/carbon-charts/
Teams like IoT are using Carbon Charts and getting Helvetica in place of Plex Condensed in all their Bar Chart versions
https://carbon-addons-iot-react.com/?path=/story/watson-iot-experimental-barchartcard--simple-bar
sample:
The text was updated successfully, but these errors were encountered: