fix(ui-shell): remove role="menuitem" from Switcher li's #5525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-components-react ready! Built with commit f6ed694 https://deploy-preview-5525--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit f6ed694 |
joshblack
approved these changes
Mar 4, 2020
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
Mar 10, 2020
…gn-system#5525) * fix(Dropdown): rely on list-box height closes carbon-design-system#4916 * fix(switcher): remove role=menuitems Co-authored-by: Josh Black <[email protected]> Co-authored-by: TJ Egan <[email protected]>
This was referenced Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5524
Removes the the
role="menuitem"attribute on the menutitems in the site switcher. They were causing DAP errors since they weren't contained in a menu.Testing
Open the UI Shell header with base actions and switcher and check to make sure the DAP errors are gone. 👍