New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site switcher menu items have incorrect role causing DAP errors #5524

Closed

dakahn opened this issue Mar 4, 2020 · 0 comments · Fixed by #5525

Assignees

Labels

component: ui-shell package: react type: a11y ♿ type: bug 🐛

Contributor

dakahn commented Mar 4, 2020

MenuItems in our site switcher incorrectly have the role="menuitem" attribute causing DAP errors.

The text was updated successfully, but these errors were encountered:

dakahn added the type: a11y ♿ label

dakahn self-assigned this

dakahn mentioned this issue

fix(ui-shell): remove role="menuitem" from Switcher li's #5525

Merged

joshblack added component: ui-shell package: react type: bug 🐛 labels

dakahn closed this as completed in #5525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment