Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dropdown] xl size doesn't work #4916

Closed
vpicone opened this issue Dec 18, 2019 · 0 comments · Fixed by #4928
Closed

[Dropdown] xl size doesn't work #4916

vpicone opened this issue Dec 18, 2019 · 0 comments · Fixed by #4928

Comments

@vpicone
Copy link
Contributor

vpicone commented Dec 18, 2019

The height is overridden by the default dropdown height.

reproduction: https://carbon-components-react.netlify.com/?path=/story/dropdown--default

  1. activate the xl knob (no effect)
  2. open dev tools and un-check the height coming from default dropdown styles
vpicone added a commit to vpicone/carbon that referenced this issue Dec 18, 2019
@vpicone
fix(Dropdown): rely on list-box height closes carbon-design-system#4916
ed6085a
asudoh added a commit to asudoh/carbon-components that referenced this issue Dec 20, 2019
@asudoh
fix(list-box): ensure size variants are in effect
615bf4d 
This change ensures the style rule in `.bx--list-box--xl` for dropdown
size wins over one in `.bx--dropdown` or any ones in applicatoin styles
(for default size), by expressing that they are for non-default styles
and should win order the one for the default size.

Fixes carbon-design-system#4916.
@asudoh asudoh mentioned this issue Dec 20, 2019
Merged
asudoh added a commit that referenced this issue Jan 15, 2020
@asudoh
fix(list-box): ensure size variants are in effect (#4928)
0e4d6a8 
This change ensures the style rule in `.bx--list-box--xl` for dropdown
size wins over one in `.bx--dropdown` by adding dropdown-specific size
class names in addition to list box ones.

Fixes #4916.
joshblack pushed a commit that referenced this issue Jan 16, 2020
@dakahn @tw15egan @joshblack
fix(structured-list): fix DAP errors (#5066)
715824f 
* fix(Dropdown): rely on list-box height closes #4916

* fix(structuredlist): remove role=presentation, remove htmlFor attribute

Co-authored-by: TJ Egan <[email protected]>
joshblack pushed a commit to joshblack/carbon that referenced this issue Jan 23, 2020
@dakahn @tw15egan @joshblack
fix(structured-list): fix DAP errors (carbon-design-system#5066)
0f1f287 
* fix(Dropdown): rely on list-box height closes carbon-design-system#4916

* fix(structuredlist): remove role=presentation, remove htmlFor attribute

Co-authored-by: TJ Egan <[email protected]>
dakahn added a commit that referenced this issue Mar 5, 2020
@dakahn @joshblack @tw15egan
fix(ui-shell): remove role="menuitem" from Switcher li's (#5525)
58f262b 
* fix(Dropdown): rely on list-box height closes #4916

* fix(switcher): remove role=menuitems

Co-authored-by: Josh Black <[email protected]>
Co-authored-by: TJ Egan <[email protected]>
dakahn added a commit that referenced this issue Mar 6, 2020
@dakahn @tw15egan @joshblack
fix(button): remove role="button" from button styled anchors (#5522)
fc2b2a9 
* fix(Dropdown): rely on list-box height closes #4916

* fix(button): add aria label to non button element button

* test(button): add a test checking that <a> button's get an aria-label

* fix(button): undo previous changes; remove role=button for anchor

* test(button): remove unneeded test for role

Co-authored-by: TJ Egan <[email protected]>
Co-authored-by: Josh Black <[email protected]>
joshblack added a commit to joshblack/carbon that referenced this issue Mar 10, 2020
@dakahn @joshblack @tw15egan
fix(ui-shell): remove role="menuitem" from Switcher li's (carbon-desi…
80d767b 
…gn-system#5525)

* fix(Dropdown): rely on list-box height closes carbon-design-system#4916

* fix(switcher): remove role=menuitems

Co-authored-by: Josh Black <[email protected]>
Co-authored-by: TJ Egan <[email protected]>
joshblack added a commit to joshblack/carbon that referenced this issue Mar 10, 2020
@dakahn @tw15egan @joshblack
fix(button): remove role="button" from button styled anchors (carbon-…
76e97f7 
…design-system#5522)

* fix(Dropdown): rely on list-box height closes carbon-design-system#4916

* fix(button): add aria label to non button element button

* test(button): add a test checking that <a> button's get an aria-label

* fix(button): undo previous changes; remove role=button for anchor

* test(button): remove unneeded test for role

Co-authored-by: TJ Egan <[email protected]>
Co-authored-by: Josh Black <[email protected]>
dakahn added a commit that referenced this issue Apr 29, 2020
@dakahn @vpicone @joshblack
Refactor/update multiselect tests (#5951)
f107c20 
* fix(Dropdown): rely on list-box height closes #4916

* test(multiselect): update tests to RTLish style

* test(project): update snapshots

* chore(tests): update snapshots

* Update packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js

Co-Authored-By: Josh Black <[email protected]>

* Update packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js

Co-Authored-By: Josh Black <[email protected]>

* Update packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js

Co-Authored-By: Josh Black <[email protected]>

* Update packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js

Co-Authored-By: Josh Black <[email protected]>

* Update packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js

Co-Authored-By: Josh Black <[email protected]>

* Update packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js

Co-Authored-By: Josh Black <[email protected]>

* Update packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js

Co-Authored-By: Josh Black <[email protected]>

* fix(multiselect-test): remove unused import

* test(FilterableMultiselect): remove checks against state

* Update packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js

Co-Authored-By: Josh Black <[email protected]>

* Update packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js

Co-Authored-By: Josh Black <[email protected]>

* Update packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js

Co-Authored-By: Josh Black <[email protected]>

* Update packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js

Co-Authored-By: Josh Black <[email protected]>

* Update packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js

Co-Authored-By: Josh Black <[email protected]>

* Update packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js

Co-Authored-By: Josh Black <[email protected]>

* test(multiselect): fix undefined vars

Co-authored-by: Vince Picone <[email protected]>
Co-authored-by: Josh Black <[email protected]>
dakahn added a commit that referenced this issue May 7, 2020
@dakahn @vpicone
@joshblack @tw15egan
feat(react): upgrade downshift dependency to v5 (#5373)
3bf2eec 
* fix(Dropdown): rely on list-box height closes #4916

* feat(react): update Downshift to v2.2.3

* feat(react): update Downshift to v3.4.8

* feat(react): update Downshift to v4.1.0

* feat(react): upgrade downshift to v5

* fix(react): add prop adapter for downshift depreacations from v1 to v5

* fix(react): add propAdapter for downshift v3 breaking changes

* fix(react): add propAdapter for downshift v3 breaking changes

* test(react): add propadapter test

* fix(react): update createPropAdapter comment to be better

* fix(combobox): add getMenuProps override

* fix(list-box): change psuedo selector to match Downshift changes

* fix(dropdown): get menu items speaking in NVDA again

* fix(dropdown): fix dap violations

* fix(dropdown): remove refkey

* fix(dropdown): remove refkey/unused aria

* fix(dropdown): remove refkey for real

* fix(dropdown): various changes of varying importance

* fix(listbox): update downshift usage for dropdown

* fix(react): removed weird dir I accidentally added

* fix(dropdown): add inputprops id

* fix(dropdown): add useState implementation

* fix(dropdown): convert to useSelect

* fix(dropdown): convert to useSelect hook w/ListBox

* fix(dropdown): add button reset

* fix(dropdown): style dropdown button

* fix(dropdown): un-nest button selector

* fix(combobox/dropdown): nits/style/bug tweaks

* fix(dropdown): add translateWithId and initialSelectedItem props

* fix(dropdown): add back css reset

* fix(dropdown): update tests

* fix(combobox): remove incorrectly set innerref

* fix(combobox): remove incorrectly set innerref

* fix(combobox): update tests and remove unneeded aria

* fix(combobox): add combobox test helpers and fix broke tests

* fix(multiselect): update tests

* test(listbox): update test helpers and snapshots

* test(listbox): update test helpers and snapshots

* fix(tests): update snapshots

* fix(test): remove empty createPropAdapter-test file

* test(dropdown): update snapshots

* fix(combobox): remove _menu added to referenced id

* fix(combobox): add back accidentally removed disabled

* fix(multiselect): refactor for useSelect hook

* chore: check-in work

* fix(multiselect): update state logic for selecting options

* fix(tools): add banner to createPropAdapter

* fix(dropdown/listbox): address styling regressions

* fix(dropdown): hide helper text in inline

* chore(tests): update snapshots

* chore(tag): update formatting to fix invalid CSS

* fix(multiselect): remove old reference file

* chore(test): update snapshots

* chore(colors): add back in scss folder

* Update packages/components/src/components/dropdown/_dropdown.scss

Co-Authored-By: Josh Black <[email protected]>

* Update packages/components/src/components/dropdown/_dropdown.scss

Co-Authored-By: Josh Black <[email protected]>

* Update packages/react/src/components/Dropdown/Dropdown.js

Co-Authored-By: Josh Black <[email protected]>

* fix(dropdown): fix type

* Update packages/components/src/components/list-box/_list-box.scss

Co-Authored-By: Josh Black <[email protected]>

* fix(combobox): remove ms-clear

* fix(multiselect): add null check for selectedItems

* fix(filterable-multiselect): add unique id for checkbox

* fix(filterable-multiselect): add role=group to menu

* fix(listbox): add outline border to fix jitter

* fix(dropdown/listbo): remove unused outline and changed border type

* fix(multiselect): change field type to fix broken labeling

* chore(tests): update snapshots

* fix(filterablemultiselect): fix incorrect field name

* fix(dropdown): add inline story variant and removed knob

* fix(listbox): remove hover styles for disabled

* test(react): update snapshots

* fix(tests): update multiselect tests

* test(multiselect): fix broken onCheange check

* test(multiselect): build out more tests

* test(FilterableMultiSelect): update tests to pass

* test(checkbox): remove irrelevent tests

* Update packages/react/src/components/Dropdown/Dropdown-story.js

Co-authored-by: Josh Black <[email protected]>

* fix(checkbox): rollback changes to id prop

* fix(dropdown): add direction prop

* fix(multiselect): add back direction prop

* test(dropdown): update snappies

* fix(listbox): add height adjustment to get label lined up

Co-authored-by: Vince Picone <[email protected]>
Co-authored-by: Josh Black <[email protected]>
Co-authored-by: TJ Egan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(list-box): ensure size variants are in effect asudoh/carbon-components
1 participant
@vpicone