Refactor/update multiselect tests #5951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 9226e73 |
|
Deploy preview for carbon-components-react ready! Built with commit 9226e73 https://deploy-preview-5951--carbon-components-react.netlify.app |
joshblack
suggested changes
Apr 28, 2020
packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js
Outdated
Show resolved
Hide resolved
…/carbon into refactor/update-multiselect-tests
…t-test.js Co-Authored-By: Josh Black <[email protected]>
…t-test.js Co-Authored-By: Josh Black <[email protected]>
…t-test.js Co-Authored-By: Josh Black <[email protected]>
…t-test.js Co-Authored-By: Josh Black <[email protected]>
…t-test.js Co-Authored-By: Josh Black <[email protected]>
…t-test.js Co-Authored-By: Josh Black <[email protected]>
…t-test.js Co-Authored-By: Josh Black <[email protected]>
…/carbon into refactor/update-multiselect-tests
joshblack
approved these changes
Apr 29, 2020
packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/MultiSelect/__tests__/MultiSelect-test.js
Outdated
Show resolved
Hide resolved
…t-test.js Co-Authored-By: Josh Black <[email protected]>
…t-test.js Co-Authored-By: Josh Black <[email protected]>
…t-test.js Co-Authored-By: Josh Black <[email protected]>
…t-test.js Co-Authored-By: Josh Black <[email protected]>
…t-test.js Co-Authored-By: Josh Black <[email protected]>
…t-test.js Co-Authored-By: Josh Black <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a total overhaul of Multiselect-test.js and a minor touch up to FilterableMultiselect-test.js. The previous tests were all written with a class based React component in mind. And with the updates to Downshift coming and this component having been refactored to be a non-class hooks based React component the new tests are written in something akin to an RTL style (how and end user might interact with the component).
Changelog
Changed
Notes
There are a few tests marked
.skip. This is either due to current functionality being unavailable or bugged.Testing / Reviewing
Run
yarn test __tests__/MultiSelect-test.js __tests__/FilterableMultiSelect-test.jsin the root project folder and see no errors.